Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 142263002: Make Window.alert/confirm/prompt default values the empty string (Closed)

Created:
6 years, 11 months ago by philipj_slow
Modified:
6 years, 11 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, arv+blink, Inactive, watchdog-blink-watchlist_google.com
Visibility:
Public.

Description

Make Window.alert/confirm/prompt default values the empty string http://whatwg.org/html#the-window-object Ad-hoc testing in Firefox Nightly and Opera 12.16 (Presto) reveal that these browsers already treat missing arguments as the empty string. Since this is not Web-exposed behavior, the risk is low. The test case description no longer made sense, so rather than writing new instructions for manual testing, just let -expected.txt say it. BUG=335855 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165443

Patch Set 1 #

Patch Set 2 : sync test expectation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -11 lines) Patch
M LayoutTests/fast/dom/Window/alert-undefined.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/dom/Window/alert-undefined-expected.txt View 1 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/frame/Window.idl View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
philipj_slow
6 years, 11 months ago (2014-01-18 09:22:29 UTC) #1
abarth-chromium
lgtm
6 years, 11 months ago (2014-01-18 09:28:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/142263002/40001
6 years, 11 months ago (2014-01-18 09:28:34 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=8087
6 years, 11 months ago (2014-01-18 13:33:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/142263002/40001
6 years, 11 months ago (2014-01-18 13:56:10 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=8096
6 years, 11 months ago (2014-01-18 16:37:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/142263002/40001
6 years, 11 months ago (2014-01-19 02:04:00 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=8112
6 years, 11 months ago (2014-01-19 04:14:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/142263002/40001
6 years, 11 months ago (2014-01-19 04:44:27 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=8119
6 years, 11 months ago (2014-01-19 07:48:56 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/142263002/40001
6 years, 11 months ago (2014-01-20 02:21:07 UTC) #11
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=8170
6 years, 11 months ago (2014-01-20 05:32:53 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/142263002/40001
6 years, 11 months ago (2014-01-21 08:31:37 UTC) #13
commit-bot: I haz the power
6 years, 11 months ago (2014-01-21 09:19:35 UTC) #14
Message was sent while issue was closed. 
Change committed as 165443

Powered by Google App Engine
This is Rietveld 408576698