Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Unified Diff: pkg/compiler/lib/src/ssa/codegen.dart

Issue 1422623014: Add TypeUse. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Updated cf. comments. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/ssa/builder.dart ('k') | pkg/compiler/lib/src/ssa/ssa.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/ssa/codegen.dart
diff --git a/pkg/compiler/lib/src/ssa/codegen.dart b/pkg/compiler/lib/src/ssa/codegen.dart
index 5ce317ae459976d3308e4aee183e397f583abfc9..dc07333725eb847e480edbdd5e479cc09a7150b1 100644
--- a/pkg/compiler/lib/src/ssa/codegen.dart
+++ b/pkg/compiler/lib/src/ssa/codegen.dart
@@ -2502,7 +2502,7 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
void checkTypeViaProperty(HInstruction input, DartType type,
SourceInformation sourceInformation,
{bool negative: false}) {
- registry.registerIsCheck(type);
+ registry.registerTypeUse(new TypeUse.isCheck(type));
use(input);
@@ -2523,7 +2523,7 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
HInstruction input, DartType type,
SourceInformation sourceInformation,
{bool negative: false}) {
- registry.registerIsCheck(type);
+ registry.registerTypeUse(new TypeUse.isCheck(type));
use(input);
@@ -2615,7 +2615,7 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
void emitIs(HIs node, String relation, SourceInformation sourceInformation) {
DartType type = node.typeExpression;
- registry.registerIsCheck(type);
+ registry.registerTypeUse(new TypeUse.isCheck(type));
HInstruction input = node.expression;
// If this is changed to single == there are several places below that must
@@ -2787,9 +2787,10 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
if (type.isFunctionType) {
// TODO(5022): We currently generate $isFunction checks for
// function types.
- registry.registerIsCheck(compiler.coreTypes.functionType);
+ registry.registerTypeUse(
+ new TypeUse.isCheck(compiler.coreTypes.functionType));
}
- registry.registerIsCheck(type);
+ registry.registerTypeUse(new TypeUse.isCheck(type));
CheckedModeHelper helper;
if (node.isBooleanConversionCheck) {
« no previous file with comments | « pkg/compiler/lib/src/ssa/builder.dart ('k') | pkg/compiler/lib/src/ssa/ssa.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698