Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1422623014: Add TypeUse. (Closed)

Created:
5 years, 1 month ago by Johnni Winther
Modified:
5 years, 1 month ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org, Siggi Cherem (dart-lang)
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 6

Patch Set 2 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+271 lines, -260 lines) Patch
M pkg/compiler/lib/src/common/codegen.dart View 3 chunks +5 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend.dart View 1 chunk +5 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/dart_backend.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/deferred_load.dart View 2 chunks +22 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 3 chunks +27 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 5 chunks +60 lines, -44 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/codegen.dart View 4 chunks +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/js_backend.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 1 13 chunks +28 lines, -18 lines 0 comments Download
M pkg/compiler/lib/src/resolution/registry.dart View 6 chunks +8 lines, -26 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/signatures.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/variables.dart View 2 chunks +5 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/codegen.dart View 4 chunks +6 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/ssa/ssa.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/universe/use.dart View 2 chunks +60 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/universe/world_impact.dart View 8 chunks +24 lines, -124 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
Main changes in universe/use.dart and universe/world_impact.dart
5 years, 1 month ago (2015-11-04 10:09:47 UTC) #2
sigurdm
LGTM https://codereview.chromium.org/1422623014/diff/1/pkg/compiler/lib/src/enqueue.dart File pkg/compiler/lib/src/enqueue.dart (right): https://codereview.chromium.org/1422623014/diff/1/pkg/compiler/lib/src/enqueue.dart#newcode172 pkg/compiler/lib/src/enqueue.dart:172: worldImpact.typeUses.forEach(registerTypeUse); Should you not special-case checked_mode_checks here? https://codereview.chromium.org/1422623014/diff/1/pkg/compiler/lib/src/enqueue.dart#newcode643 ...
5 years, 1 month ago (2015-11-04 10:37:31 UTC) #3
Johnni Winther
Committed patchset #2 (id:20001) manually as 383719431113935e4352126d59f9994069bb84df (presubmit successful).
5 years, 1 month ago (2015-11-04 13:29:28 UTC) #4
Johnni Winther
5 years, 1 month ago (2015-11-04 13:41:10 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/1422623014/diff/1/pkg/compiler/lib/src/enqueu...
File pkg/compiler/lib/src/enqueue.dart (right):

https://codereview.chromium.org/1422623014/diff/1/pkg/compiler/lib/src/enqueu...
pkg/compiler/lib/src/enqueue.dart:172:
worldImpact.typeUses.forEach(registerTypeUse);
On 2015/11/04 10:37:31, sigurdm wrote:
> Should you not special-case checked_mode_checks here?

This is now done in registerTypeUse

https://codereview.chromium.org/1422623014/diff/1/pkg/compiler/lib/src/enqueu...
pkg/compiler/lib/src/enqueue.dart:643: registerInstantiatedType(type);
On 2015/11/04 10:37:31, sigurdm wrote:
> can `registerInstantiatedType` be private now?

Not yet, but we are getting closer.

https://codereview.chromium.org/1422623014/diff/1/pkg/compiler/lib/src/resolu...
File pkg/compiler/lib/src/resolution/members.dart (right):

https://codereview.chromium.org/1422623014/diff/1/pkg/compiler/lib/src/resolu...
pkg/compiler/lib/src/resolution/members.dart:4167: // TODO(johnniwinther): The
should be a consequence of the registration below.
On 2015/11/04 10:37:31, sigurdm wrote:
> Sentence is broken. Long line.

Done.

Powered by Google App Engine
This is Rietveld 408576698