Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1422623013: [turbofan] Extend typer support for typeof operator. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Extend typer support for typeof operator. R=jarin@chromium.org Committed: https://crrev.com/a2fdcc26ee0cd9870d85d4747bd9ea6ca1a35eeb Cr-Commit-Position: refs/heads/master@{#31770}

Patch Set 1 #

Patch Set 2 : Reduce to obvious cases. REBASE. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M src/compiler/typer.cc View 1 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Benedikt Meurer
5 years, 1 month ago (2015-11-03 13:59:31 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1422623013/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1422623013/1
5 years, 1 month ago (2015-11-03 17:39:23 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-03 17:56:16 UTC) #5
Jarin
lgtm
5 years, 1 month ago (2015-11-04 07:19:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1422623013/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1422623013/20001
5 years, 1 month ago (2015-11-04 07:19:43 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-04 07:21:10 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-04 07:21:43 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/a2fdcc26ee0cd9870d85d4747bd9ea6ca1a35eeb
Cr-Commit-Position: refs/heads/master@{#31770}

Powered by Google App Engine
This is Rietveld 408576698