Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1422623003: Revert of SkTime::GetNSecs() (Closed)

Created:
5 years, 2 months ago by mtklein
Modified:
5 years, 2 months ago
Reviewers:
caryclark, mtklein_C, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of SkTime::GetNSecs() (patchset #11 id:200001 of https://codereview.chromium.org/1422513003/ ) Reason for revert: Times don't look like they make sense on Windows. Original issue's description: > SkTime::GetNSecs() > > - Move high-precision wall timers from tools/timer to SkTime. > - Implement SkTime::GetMSecs() in terms of SkTime::GetNSecs(). > - Delete unused tools/timer code. > > I have no idea what's going on there in src/animator. > I don't intend to investigate. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/70084cbc16ee8162649f2601377feb6e49de0217 > > CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Debug-CrOS_Link-Trybot > > Committed: https://skia.googlesource.com/skia/+/a1840d50e29fd95e4df2d1168fe54c34c2a5c30c > > Committed: https://skia.googlesource.com/skia/+/38a88e4c0c28a7be981aac7bb4a198ad95a62a63 TBR=caryclark@google.com,reed@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/3b5b7845428a94402c1984c175ecce83cc963c21

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+817 lines, -32 lines) Patch
M gyp/tools.gyp View 1 chunk +30 lines, -2 lines 0 comments Download
M include/core/SkTime.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/animator/SkTime.cpp View 2 chunks +18 lines, -0 lines 0 comments Download
M src/core/SkTime.cpp View 1 chunk +0 lines, -23 lines 0 comments Download
M src/ports/SkTime_Unix.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M src/ports/SkTime_win.cpp View 1 chunk +11 lines, -0 lines 0 comments Download
A tools/timer/GpuTimer.h View 1 chunk +25 lines, -0 lines 0 comments Download
A tools/timer/GpuTimer.cpp View 1 chunk +77 lines, -0 lines 0 comments Download
A tools/timer/SysTimer_mach.h View 1 chunk +24 lines, -0 lines 0 comments Download
A tools/timer/SysTimer_mach.cpp View 1 chunk +66 lines, -0 lines 0 comments Download
A tools/timer/SysTimer_posix.h View 1 chunk +23 lines, -0 lines 0 comments Download
A tools/timer/SysTimer_posix.cpp View 1 chunk +51 lines, -0 lines 0 comments Download
A tools/timer/SysTimer_windows.h View 1 chunk +25 lines, -0 lines 0 comments Download
A tools/timer/SysTimer_windows.cpp View 1 chunk +53 lines, -0 lines 0 comments Download
M tools/timer/Timer.h View 1 chunk +55 lines, -5 lines 0 comments Download
M tools/timer/Timer.cpp View 1 chunk +46 lines, -0 lines 0 comments Download
A tools/timer/TimerData.h View 1 chunk +85 lines, -0 lines 0 comments Download
A tools/timer/TimerData.cpp View 1 chunk +220 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mtklein
Created Revert of SkTime::GetNSecs()
5 years, 2 months ago (2015-10-23 13:40:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1422623003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1422623003/1
5 years, 2 months ago (2015-10-23 13:40:20 UTC) #2
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 13:40:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3b5b7845428a94402c1984c175ecce83cc963c21

Powered by Google App Engine
This is Rietveld 408576698