Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: shell/BUILD.gn

Issue 1422623002: Build fixes for fnl/musl (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: update README.chromium in //third_party Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/native_support/make_pty_pair.cc ('k') | third_party/libevent/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: shell/BUILD.gn
diff --git a/shell/BUILD.gn b/shell/BUILD.gn
index ab2b534272649b34c29c60e4cc8a3a3270edc654..43a1bb6dcf7b410d571f0eef0f69b7b0354e5ab6 100644
--- a/shell/BUILD.gn
+++ b/shell/BUILD.gn
@@ -39,7 +39,9 @@ group("tests") {
"//shell/application_manager:mojo_application_manager_unittests",
]
- if (is_android || is_linux) {
+ # TODO(cstout): fix breakpad build for fnl/musl
+ # https://code.google.com/p/google-breakpad/issues/detail?id=631
+ if ((is_android || is_linux) && !is_fnl) {
deps += [ "//shell/crash:crash_unittests" ]
}
}
@@ -60,7 +62,9 @@ if (!mojo_use_prebuilt_mojo_shell) {
]
shell_common_data_deps = [ ":mojo_shell_child" ]
- if (is_android || is_linux) {
+ # TODO(cstout): fix breakpad build for fnl/musl
+ # (see comment above)
+ if ((is_android || is_linux) && !is_fnl) {
shell_common_deps += [ "//shell/crash" ]
}
« no previous file with comments | « services/native_support/make_pty_pair.cc ('k') | third_party/libevent/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698