third_party/WebKit/Source/core/html/HTMLFieldSetElement.cpp - Issue 1422573006: Disabled FIELDSET elements should not be focusable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLFieldSetElement.cpp

Issue 1422573006: Disabled FIELDSET elements should not be focusable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix for fast/events/tabindex-focus-blur-all.html Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/html/HTMLFieldSetElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLFieldSetElement.cpp b/third_party/WebKit/Source/core/html/HTMLFieldSetElement.cpp

index dc5accdde9a6aacb503ef1182ec0e3cb340acaa0..e113b1b589966a8ff729158b4dff61b23adbaeab 100644

--- a/third_party/WebKit/Source/core/html/HTMLFieldSetElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLFieldSetElement.cpp

@@ -103,7 +103,7 @@ void HTMLFieldSetElement::childrenChanged(const ChildrenChange& change)

bool HTMLFieldSetElement::supportsFocus() const

{

- return HTMLElement::supportsFocus();

+ return HTMLElement::supportsFocus() && !isDisabledFormControl();

}

const AtomicString& HTMLFieldSetElement::formControlType() const

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-disabled-expected.txt ('k') | no next file » | no next file with comments »