Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 1422573002: [turbofan] Initial support for monomorphic/polymorphic property stores. (Closed)

Created:
5 years, 2 months ago by Benedikt Meurer
Modified:
5 years, 2 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Initial support for monomorphic/polymorphic property stores. This slightly generalizes the current mechnanism for property loads to also deal with property stores (both monomorphic and polymorphic). It's still somewhat adhoc, but it already handles a lot of the interesting cases. We might want to wait for keyed accesses before we start refactoring to a more general solution. R=jarin@chromium.org BUG=v8:4470 LOG=n Committed: https://crrev.com/74b414675765adb2d7f5dba4b5fff24976976a7f Cr-Commit-Position: refs/heads/master@{#31475}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+311 lines, -44 lines) Patch
M src/compiler/js-native-context-specialization.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 16 chunks +307 lines, -44 lines 3 comments Download

Messages

Total messages: 8 (1 generated)
Benedikt Meurer
5 years, 2 months ago (2015-10-21 13:38:46 UTC) #1
Benedikt Meurer
Hey Jaro, As discussed offline, here's the patch without refactoring. Please take a look. Thanks, ...
5 years, 2 months ago (2015-10-21 13:42:45 UTC) #2
Jarin
lgtm. (sigh.) https://codereview.chromium.org/1422573002/diff/1/src/compiler/js-native-context-specialization.cc File src/compiler/js-native-context-specialization.cc (right): https://codereview.chromium.org/1422573002/diff/1/src/compiler/js-native-context-specialization.cc#newcode820 src/compiler/js-native-context-specialization.cc:820: // common code once we also have ...
5 years, 2 months ago (2015-10-22 09:27:30 UTC) #3
Benedikt Meurer
https://codereview.chromium.org/1422573002/diff/1/src/compiler/js-native-context-specialization.cc File src/compiler/js-native-context-specialization.cc (right): https://codereview.chromium.org/1422573002/diff/1/src/compiler/js-native-context-specialization.cc#newcode820 src/compiler/js-native-context-specialization.cc:820: // common code once we also have support for ...
5 years, 2 months ago (2015-10-22 11:38:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1422573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1422573002/1
5 years, 2 months ago (2015-10-22 13:22:11 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-22 13:23:24 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-22 13:23:53 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/74b414675765adb2d7f5dba4b5fff24976976a7f
Cr-Commit-Position: refs/heads/master@{#31475}

Powered by Google App Engine
This is Rietveld 408576698