Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Unified Diff: net/tools/quic/end_to_end_test.cc

Issue 1422563005: Remove unused method OnPacketSent from QuicPacketDroppingTestWriter::Delegate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@106458891
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/tools/quic/test_tools/packet_dropping_test_writer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/end_to_end_test.cc
diff --git a/net/tools/quic/end_to_end_test.cc b/net/tools/quic/end_to_end_test.cc
index a91b2c74f57e73e841ae04212ffd21914266566d..5fc6ca93be037753934aea8357ce19003f5917ff 100644
--- a/net/tools/quic/end_to_end_test.cc
+++ b/net/tools/quic/end_to_end_test.cc
@@ -211,18 +211,12 @@ vector<TestParams> GetTestParams() {
class ServerDelegate : public PacketDroppingTestWriter::Delegate {
public:
- ServerDelegate(TestWriterFactory* writer_factory,
- QuicDispatcher* dispatcher)
- : writer_factory_(writer_factory),
- dispatcher_(dispatcher) {}
+ explicit ServerDelegate(QuicDispatcher* dispatcher)
+ : dispatcher_(dispatcher) {}
~ServerDelegate() override {}
- void OnPacketSent(WriteResult result) override {
- writer_factory_->OnPacketSent(result);
- }
void OnCanWrite() override { dispatcher_->OnCanWrite(); }
private:
- TestWriterFactory* writer_factory_;
QuicDispatcher* dispatcher_;
};
@@ -230,7 +224,6 @@ class ClientDelegate : public PacketDroppingTestWriter::Delegate {
public:
explicit ClientDelegate(QuicClient* client) : client_(client) {}
~ClientDelegate() override {}
- void OnPacketSent(WriteResult /*result*/) override {}
void OnCanWrite() override {
EpollEvent event(EPOLLOUT, false);
client_->OnEvent(client_->fd(), &event);
@@ -412,7 +405,7 @@ class EndToEndTest : public ::testing::TestWithParam<TestParams> {
server_writer_->Initialize(
QuicDispatcherPeer::GetHelper(dispatcher),
- new ServerDelegate(packet_writer_factory, dispatcher));
+ new ServerDelegate(dispatcher));
if (stream_factory_ != nullptr) {
static_cast<QuicTestServer*>(server_thread_->server())
->SetSpdyStreamFactory(stream_factory_);
« no previous file with comments | « no previous file | net/tools/quic/test_tools/packet_dropping_test_writer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698