Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1422543005: [tools] Fix regexp grepping for GC NVP float values. (Closed)

Created:
5 years, 2 months ago by Michael Lippautz
Modified:
5 years, 2 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[tools] Fix regexp grepping for GC NVP float values. R=ulan@chromium.org Committed: https://crrev.com/c610c6308d6ed3df6c3ce91b803992c207f7f5b7 Cr-Commit-Position: refs/heads/master@{#31448}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/gc_nvp_common.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Michael Lippautz
PTAL
5 years, 2 months ago (2015-10-21 17:00:22 UTC) #3
ulan
lgtm
5 years, 2 months ago (2015-10-21 17:09:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1422543005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1422543005/1
5 years, 2 months ago (2015-10-21 17:10:35 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-21 17:33:35 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-21 17:34:05 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c610c6308d6ed3df6c3ce91b803992c207f7f5b7
Cr-Commit-Position: refs/heads/master@{#31448}

Powered by Google App Engine
This is Rietveld 408576698