Support SAB atomics for offset-TypedArray

Support SAB atomics for offset-TypedArray

BUG=497295
LOG=n

Committed: https://crrev.com/81fe5b3c455525af36e6754dc54e4430d217d6c8
Cr-Commit-Position: refs/heads/master@{#32064}

[Pan, 2015-11-04 06:44:03]

Description was changed from

==========
Support SAB atomics for offset-TypedArray

BUG=497295
==========

to

==========
Support SAB atomics for offset-TypedArray

BUG=497295
==========

[Pan, 2015-11-04 06:44:03]

pan.deng@intel.com changed reviewers:
+ binji@chromium.org

[Pan, 2015-11-04 06:56:32]

@binji,

I was tasting SAB in d8/chrome, and find such case:
var sab = new SharedArrayBuffer(16);
var i32array = new Int32Array(sab, 8, 2);
i32array[0] = 20;
print(20 === Atomics.load(i32array, 0)); // expect True, but actually false.

The reason is offset of bufferview is not handled in Atomics ops.
please take a look

thanks
Pan

[binji, 2015-11-09 19:33:09]

Nice catch, thanks for looking at this!

Looks good so far. The tests you've modified are the asm.js tests, please add
tests to test/harmony/atomics.js as well.

[Pan, 2015-11-11 08:11:23]

On 2015/11/09 19:33:09, binji wrote:
> Nice catch, thanks for looking at this!
> 
> Looks good so far. The tests you've modified are the asm.js tests, please add
> tests to test/harmony/atomics.js as well.

case harmony/atomics is added, PTAL.

thanks
Pan

[Pan, 2015-11-16 11:58:29]

On 2015/11/11 08:11:23, Pan wrote:
> On 2015/11/09 19:33:09, binji wrote:
> > Nice catch, thanks for looking at this!
> > 
> > Looks good so far. The tests you've modified are the asm.js tests, please
add
> > tests to test/harmony/atomics.js as well.
> 
> case harmony/atomics is added, PTAL.
> 
> thanks
> Pan

@binji, ping?

[binji, 2015-11-16 19:54:45]

sorry, was out sick last week :(

lgtm

[Pan, 2015-11-17 00:22:37]

The CQ bit was checked by pan.deng@intel.com

[commit-bot: I haz the power, 2015-11-17 00:22:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1422533009/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1422533009/20001

[commit-bot: I haz the power, 2015-11-17 00:26:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-17 00:26:31]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/7768)

[Pan, 2015-11-17 00:39:23]

pan.deng@intel.com changed reviewers:
+ jarin@chromium.org

[Pan, 2015-11-17 00:39:23]

@jarin,
could you please take a look?

thanks
Pan

[Jarin, 2015-11-17 09:15:53]

On 2015/11/17 00:39:23, Pan wrote:
> @jarin,
> could you please take a look?
> 
> thanks
> Pan

lgtm. Should not we do the same thing for futexes?

[binji, 2015-11-17 19:23:52]

On 2015/11/17 09:15:53, Jarin wrote:
> On 2015/11/17 00:39:23, Pan wrote:
> > @jarin,
> > could you please take a look?
> > 
> > thanks
> > Pan
> 
> lgtm. Should not we do the same thing for futexes?

Good catch, those will have the same issue. I'm OK with filing a bug and
following up on that in another CL.

I filed https://code.google.com/p/v8/issues/detail?id=4555.

[Pan, 2015-11-18 00:05:31]

The CQ bit was checked by pan.deng@intel.com

[commit-bot: I haz the power, 2015-11-18 00:05:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1422533009/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1422533009/20001

[commit-bot: I haz the power, 2015-11-18 00:08:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-18 00:08:01]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/7832)

[Pan, 2015-11-18 00:18:14]

Description was changed from

==========
Support SAB atomics for offset-TypedArray

BUG=497295
==========

to

==========
Support SAB atomics for offset-TypedArray

BUG=497295
LOG=n
==========

[Pan, 2015-11-18 00:18:21]

The CQ bit was checked by pan.deng@intel.com

[commit-bot: I haz the power, 2015-11-18 00:18:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1422533009/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1422533009/20001

[commit-bot: I haz the power, 2015-11-18 00:19:47]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-18 00:20:06]

Patchset 2 (id:??) landed as
https://crrev.com/81fe5b3c455525af36e6754dc54e4430d217d6c8
Cr-Commit-Position: refs/heads/master@{#32064}