Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1422533006: Merge GetIncomingDynamicStream and GetDynamicStream into a single GetOrCreateDynamicStream method i… (Closed)

Created:
5 years, 1 month ago by Ryan Hamilton
Modified:
5 years, 1 month ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@106419223
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Merge GetIncomingDynamicStream and GetDynamicStream into a single GetOrCreateDynamicStream method in QuicSession. No behavior change. Merge internal change: 106421704 R=rtennet@chromium.org BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -64 lines) Patch
M net/quic/quic_session.h View 1 chunk +5 lines, -3 lines 0 comments Download
M net/quic/quic_session.cc View 4 chunks +9 lines, -25 lines 0 comments Download
M net/quic/quic_session_test.cc View 9 chunks +18 lines, -18 lines 0 comments Download
M net/quic/quic_spdy_session.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/test_tools/quic_session_peer.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/test_tools/quic_session_peer.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/tools/quic/quic_server_session_test.cc View 8 chunks +11 lines, -11 lines 0 comments Download

Depends on Patchset:

Issue 1433433003 Patch 1

Dependent Patchsets:

Issue 1408963003 Patch 1

Messages

Total messages: 4 (2 generated)
Ryan Hamilton
5 years, 1 month ago (2015-11-02 20:21:20 UTC) #1
ramant (doing other things)
5 years, 1 month ago (2015-11-03 00:37:24 UTC) #4 
lgtm

Powered by Google App Engine
This is Rietveld 408576698