Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1422513004: Merge to XFA: Add type cast definitions for CPDF_Stream. (Closed)

Created:
5 years, 2 months ago by dsinclair
Modified:
5 years, 2 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Add type cast definitions for CPDF_Stream. This Cl adds ToStream, CPDF_Object::AsStream and CPDF_Object::IsStream and updates the src to use them as needed. BUG=pdfium:201 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1402413004 . (cherry picked from commit 338805f1366dcdf9a5b48cf591541cf98d7490f1) Committed: https://pdfium.googlesource.com/pdfium/+/aa435ba7fe0aacd9102e8c73311c5382ca112439

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+325 lines, -377 lines) Patch
M core/include/fpdfapi/fpdf_objects.h View 3 chunks +11 lines, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_content.cpp View 2 chunks +8 lines, -7 lines 0 comments Download
M core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp View 6 chunks +28 lines, -37 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font.cpp View 5 chunks +29 lines, -31 lines 2 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_doc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_func.cpp View 4 chunks +14 lines, -19 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_image.cpp View 1 chunk +5 lines, -6 lines 2 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp View 3 chunks +5 lines, -6 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_pattern.cpp View 3 chunks +13 lines, -14 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_document.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp View 11 chunks +32 lines, -39 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 5 chunks +35 lines, -48 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_image.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp View 4 chunks +14 lines, -22 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_pattern.cpp View 9 chunks +76 lines, -85 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/render_int.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfdoc/doc_annot.cpp View 2 chunks +14 lines, -17 lines 0 comments Download
M core/src/fpdfdoc/doc_basic.cpp View 1 chunk +5 lines, -7 lines 0 comments Download
M core/src/fpdfdoc/doc_tagged.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M fpdfsdk/src/fpdf_flatten.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M fpdfsdk/src/fpdf_transformpage.cpp View 3 chunks +8 lines, -7 lines 0 comments Download
M fpdfsdk/src/fpdfppo.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fsdk_baseform.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
dsinclair
PTAL. Conflicts/issues marked. https://codereview.chromium.org/1422513004/diff/1/core/src/fpdfapi/fpdf_font/fpdf_font.cpp File core/src/fpdfapi/fpdf_font/fpdf_font.cpp (right): https://codereview.chromium.org/1422513004/diff/1/core/src/fpdfapi/fpdf_font/fpdf_font.cpp#newcode272 core/src/fpdfapi/fpdf_font/fpdf_font.cpp:272: const uint8_t* pFontData = m_pFontFile->GetData(); This ...
5 years, 2 months ago (2015-10-22 19:54:50 UTC) #1
Tom Sepez
lgtm https://codereview.chromium.org/1422513004/diff/1/core/src/fpdfapi/fpdf_font/fpdf_font.cpp File core/src/fpdfapi/fpdf_font/fpdf_font.cpp (right): https://codereview.chromium.org/1422513004/diff/1/core/src/fpdfapi/fpdf_font/fpdf_font.cpp#newcode272 core/src/fpdfapi/fpdf_font/fpdf_font.cpp:272: const uint8_t* pFontData = m_pFontFile->GetData(); On 2015/10/22 19:54:50, ...
5 years, 2 months ago (2015-10-22 20:44:44 UTC) #2
dsinclair
5 years, 2 months ago (2015-10-22 20:45:52 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
aa435ba7fe0aacd9102e8c73311c5382ca112439 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698