win: Add HandleToInt() and IntToHandle()

handler/main.cc

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 28 matching lines @@
 #include "base/mac/scoped_mach_port.h"
 #include "handler/mac/crash_report_exception_handler.h"
 #include "handler/mac/exception_handler_server.h"
 #include "util/mach/child_port_handshake.h"
 #include "util/mach/mach_extensions.h"
 #include "util/posix/close_stdio.h"
 #elif defined(OS_WIN)
 #include <windows.h>
 #include "handler/win/crash_report_exception_handler.h"
 #include "util/win/exception_handler_server.h"
+#include "util/win/handle.h"
 #endif  // OS_MACOSX
 
 namespace crashpad {
 namespace {
 
 void Usage(const base::FilePath& me) {
   fprintf(stderr,
 "Usage: %" PRFilePath " [OPTION]...\n"
 "Crashpad's exception handler server.\n"
 "\n"
@@ skipping 115 matching lines @@
       case kOptionMachService: {
         options.mach_service = optarg;
         break;
       }
       case kOptionResetOwnCrashExceptionPortToSystemDefault: {
         options.reset_own_crash_exception_port_to_system_default = true;
         break;
       }
 #elif defined(OS_WIN)
       case kOptionHandshakeHandle: {
-        // According to
-        // https://msdn.microsoft.com/en-us/library/windows/desktop/aa384203,
-        // HANDLEs are always 32 bits. This construction is used to read a full
-        // 32-bit number presented by the client, which uses 0x%x format, and
-        // sign-extend it.
+        // Use unsigned int, because the handle was presented by the client in
+        // 0x%x format.
         unsigned int handle_uint;
         if (!StringToNumber(optarg, &handle_uint) ||
-            (options.handshake_handle = reinterpret_cast<HANDLE>(
-                 static_cast<int>(handle_uint))) == INVALID_HANDLE_VALUE) {
+            (options.handshake_handle = IntToHandle(handle_uint)) ==
+                INVALID_HANDLE_VALUE) {
           ToolSupport::UsageHint(me, "--handshake-handle requires a HANDLE");
           return EXIT_FAILURE;
-        }
         break;
       }
       case kOptionPipeName: {
         options.pipe_name = optarg;
         break;
       }
 #endif  // OS_MACOSX
       case kOptionURL: {
         options.url = optarg;
         break;
@@ skipping 124 matching lines @@
 
 #if defined(OS_MACOSX)
 int main(int argc, char* argv[]) {
   return crashpad::HandlerMain(argc, argv);
 }
 #elif defined(OS_WIN)
 int wmain(int argc, wchar_t* argv[]) {
   return crashpad::ToolSupport::Wmain(argc, argv, crashpad::HandlerMain);
 }
 #endif  // OS_MACOSX