Issue 1422503012: Merge to XFA: Fix incorrect CPDFSDK_PageView::CountAnnots(). (try 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1422503012: Merge to XFA: Fix incorrect CPDFSDK_PageView::CountAnnots(). (try 2) (Closed)

Created:
5 years, 1 month ago by Lei Zhang

Modified:
5 years, 1 month ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Fix incorrect CPDFSDK_PageView::CountAnnots(). (try 2) The original XFA version was correct, and the master version here is wrong. The two versions are now in sync, but incorrect. So we need to fix this here and then merge to XFA again. Also fix what are now incorrect uses of CountAnnots() and do some cleanups. BUG=543049 TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1413973011 . (cherry picked from commit c91d5c276b6b986f645d34a0e583fbe4f73e74bc) Committed: https://pdfium.googlesource.com/pdfium/+/502185351be66bd6498b7aa1e1a37ed0826b7936

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -118 lines)			Patch
M	fpdfsdk/include/fsdk_mgr.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	fpdfsdk/src/fsdk_baseform.cpp	View		3 chunks	+59 lines, -107 lines	0 comments	Download
M	fpdfsdk/src/fsdk_mgr.cpp	View	1	5 chunks	+8 lines, -10 lines	0 comments	Download

Total messages: 2 (0 generated)

Lei Zhang

TBR. fpdfsdk/src/fsdk_mgr.cpp conflicted but wasn't too hard to fix up.

5 years, 1 month ago (2015-10-30 20:56:23 UTC) #1

Lei Zhang

5 years, 1 month ago (2015-10-30 21:03:50 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
502185351be66bd6498b7aa1e1a37ed0826b7936 (presubmit successful).