Oilpan: insist on persisted plugin disposal upon clearing.

Oilpan: insist on persisted plugin disposal upon clearing.

Follow up r355010 and arrange for persisted plugin widget disposal
when the plugin is completely detached and removed from the tree.

r355010 restricted disposal to not happen for persisted widgets
when re-attaching, but also ended up not disposing for the
fully-detached persistent plugin widget case.

Lacking those, widgets would end up being finalized without their
required dispose() having been called first.

R=haraken
BUG=544175
Committed: https://crrev.com/8142249a991cab98f6065e7b2c950393aa8c3bc2
Cr-Commit-Position: refs/heads/master@{#357142}

[sof, 2015-10-30 07:48:05]

sigbjornf@opera.com changed reviewers:
+ oilpan-reviews@chromium.org

[sof, 2015-10-30 07:48:05]

please take a look.

Takes care of flaky plugin asserts like


https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Win_Oilpa...

[haraken, 2015-10-30 07:48:36]

LGTM

[sof, 2015-10-30 08:36:14]

sigbjornf@opera.com changed reviewers:
+ phajdan.jr@chromium.org

[sof, 2015-10-30 08:36:14]

The Oilpan bots have undergone a change just recently (this week?) which makes
them not run webkit_tests on CLs. To wit,


http://build.chromium.org/p/tryserver.blink/builders/mac_blink_oilpan_dbg/bui...

http://build.chromium.org/p/tryserver.blink/builders/linux_blink_oilpan_rel/b...

http://build.chromium.org/p/tryserver.blink/builders/linux_blink_oilpan_dbg/b...

http://build.chromium.org/p/tryserver.blink/builders/win_blink_oilpan_dbg/bui...

Blindly landing Oilpan changes is not a good state to be in.

[sof, 2015-10-30 16:33:15]

Description was changed from

==========
Oilpan: insist on persisted plugin disposal upon clearing.

Follow up r355010 and arrange for persisted plugin widget disposal
when the plugin is completely detached and removed from the tree.

r355010 restricted disposal to not happen for persisted widgets
when re-attaching, but also ended up not disposing for the
fully-detached persistent plugin widget case.

Lacking those, widgets would end up being finalized without their
required dispose() having been called first.

R=
BUG=544175
==========

to

==========
Oilpan: insist on persisted plugin disposal upon clearing.

Follow up r355010 and arrange for persisted plugin widget disposal
when the plugin is completely detached and removed from the tree.

r355010 restricted disposal to not happen for persisted widgets
when re-attaching, but also ended up not disposing for the
fully-detached persistent plugin widget case.

Lacking those, widgets would end up being finalized without their
required dispose() having been called first.

R=haraken
BUG=544175
==========

[sof, 2015-10-30 16:33:21]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2015-10-30 16:34:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1422503009/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1422503009/1

[commit-bot: I haz the power, 2015-10-30 18:38:45]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-10-30 18:39:47]

Patchset 1 (id:??) landed as
https://crrev.com/8142249a991cab98f6065e7b2c950393aa8c3bc2
Cr-Commit-Position: refs/heads/master@{#357142}