ClientSideDetectionService model fetch should honor kSbDisableAutoUpdate switch.

chrome/browser/safe_browsing/client_side_detection_service.cc

Index: chrome/browser/safe_browsing/client_side_detection_service.cc
diff --git a/chrome/browser/safe_browsing/client_side_detection_service.cc b/chrome/browser/safe_browsing/client_side_detection_service.cc
index 7c805c2a880f81fc37ec2d6a6187adc7c5e5593b..2d190b9e5b63805642867a16f7eed98b07cab6d3 100644
--- a/chrome/browser/safe_browsing/client_side_detection_service.cc
+++ b/chrome/browser/safe_browsing/client_side_detection_service.cc
@@ -16,6 +16,7 @@
 #include "base/time.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/profiles/profile.h"
+#include "chrome/common/chrome_switches.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/safe_browsing/client_model.pb.h"
 #include "chrome/common/safe_browsing/csd.pb.h"
@@ -270,6 +271,9 @@ void ClientSideDetectionService::SendModelToRenderers() {
 }
 
 void ClientSideDetectionService::ScheduleFetchModel(int64 delay_ms) {
+  if (CommandLine::ForCurrentProcess()->HasSwitch(
+      switches::kSbDisableAutoUpdate))
+    return;

[noelutz, 2013/04/17 22:36:45]

There are two other places in this file where we issue HTTP requests.

The first one is if there is a client-side phishing hit.  This only happens if
there is a phishing model present so we should be good there given that we
always fetch it.

The second case happens if we show a malware interstitial.  Do we ever send hash
server requests if that flag is set?  Does it only disable update requests or
all SB requests?  If hash server requests are still sent then there might be a
slight chance of us sending a malware report even if that flag is set.  Is that
acceptable?

[mattm, 2013/04/17 23:12:17]

I think you're thinking of the MalwareDetails class, the malware stuff in this
file is the new malware IP blacklisting stuff kewang is working on, which also
depends on the phishing model being present, if I'm remembering correctly.

[noelutz, 2013/04/17 23:36:48]

You're absolutely right.  Thanks for refreshing my memory.

   MessageLoop::current()->PostDelayedTask(
       FROM_HERE,
       base::Bind(&ClientSideDetectionService::StartFetchModel,