Issue 14225019: Delete old user manager in ~ScopedTestCrosSettings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14225019: Delete old user manager in ~ScopedTestCrosSettings (Closed)

Created:
7 years, 8 months ago by stevenjb

Modified:
7 years, 8 months ago

Reviewers:
Derek Bruening, Mattias Nissler (ping if slow)

CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Delete old user manager in ~ScopedTestCrosSettings BUG=232924 TBR=mnissler@chromium Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194720

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -16 lines)			Patch
M	chrome/browser/chromeos/settings/cros_settings.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	tools/heapcheck/suppressions.txt	View	1	1 chunk	+0 lines, -8 lines	0 comments	Download
M	tools/valgrind/memcheck/suppressions.txt	View	1	1 chunk	+0 lines, -7 lines	0 comments	Download

Total messages: 5 (0 generated)

Derek Bruening

Please also remove the Valgrind and Heapcheck suppressions added in r194695

7 years, 8 months ago (2013-04-17 22:21:21 UTC) #2

stevenjb

On 2013/04/17 22:21:21, Derek Bruening wrote: > Please also remove the Valgrind and Heapcheck suppressions ...

7 years, 8 months ago (2013-04-17 22:23:13 UTC) #3

Derek Bruening

On 2013/04/17 22:23:13, stevenjb (chromium) wrote: > On 2013/04/17 22:21:21, Derek Bruening wrote: > > ...

7 years, 8 months ago (2013-04-17 22:24:38 UTC) #4

stevenjb

7 years, 8 months ago (2013-04-17 23:44:33 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r194720 (presubmit successful).