Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(816)

Issue 14225017: Bluetooth: treat unpairable devices as Trusted/Paired (Closed)

Created:
7 years, 8 months ago by keybuk
Modified:
7 years, 8 months ago
Reviewers:
deymo, youngki
CC:
chromium-reviews
Visibility:
Public.

Description

Bluetooth: treat unpairable devices as Trusted/Paired A small number of devices cannot be paired, but can at least be connected to insecurely. Support these by marking the devices as Trusted, which causes BlueZ to remember the device and which allows future incoming connections from them. Make IsPaired() return true for these devices, there's no reason in the UI to treat these any differently than paired devices. TBR=youngki@chromium.org BUG=232145 TEST=device_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195021

Patch Set 1 #

Patch Set 2 : deal with the Forget() case #

Patch Set 3 : Forget() change was unneeded, keep the unit test though #

Total comments: 2

Patch Set 4 : fix indentation and log message #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -33 lines) Patch
M device/bluetooth/bluetooth_device_chromeos.h View 1 2 1 chunk +5 lines, -3 lines 0 comments Download
M device/bluetooth/bluetooth_device_chromeos.cc View 2 4 chunks +18 lines, -12 lines 0 comments Download
M device/bluetooth/bluetooth_device_experimental_chromeos.h View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M device/bluetooth/bluetooth_device_experimental_chromeos.cc View 1 2 3 5 chunks +22 lines, -17 lines 0 comments Download
M device/bluetooth/bluetooth_experimental_chromeos_unittest.cc View 1 2 2 chunks +56 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
keybuk
7 years, 8 months ago (2013-04-17 21:33:31 UTC) #1
deymo
lgtm
7 years, 8 months ago (2013-04-17 22:31:22 UTC) #2
keybuk
On 2013/04/17 22:31:22, deymo wrote: > lgtm ptal - setting trusted to true means we ...
7 years, 8 months ago (2013-04-18 18:10:02 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 8 months ago (2013-04-18 18:26:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keybuk@chromium.org/14225017/18001
7 years, 8 months ago (2013-04-18 18:26:52 UTC) #5
deymo
https://chromiumcodereview.appspot.com/14225017/diff/18001/device/bluetooth/bluetooth_device_experimental_chromeos.cc File device/bluetooth/bluetooth_device_experimental_chromeos.cc (right): https://chromiumcodereview.appspot.com/14225017/diff/18001/device/bluetooth/bluetooth_device_experimental_chromeos.cc#newcode243 device/bluetooth/bluetooth_device_experimental_chromeos.cc:243: RemoveDevice( This block should have 4-space indentation instead f ...
7 years, 8 months ago (2013-04-18 18:41:11 UTC) #6
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=30292
7 years, 8 months ago (2013-04-18 22:06:41 UTC) #7
keybuk
7 years, 8 months ago (2013-04-18 22:45:33 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 manually as r195021 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698