Sets request_focus_on_press to false for message_center_buttons.

ui/message_center/views/message_center_view.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/message_center/views/message_center_view.h"
 
 #include <map>
 
 #include "grit/ui_strings.h"
 #include "ui/base/l10n/l10n_util.h"
@@ skipping 95 matching lines @@
     message_center()->RemoveAllNotifications(true);  // Action by user.
 }
 
 // NotificationCenterButton ////////////////////////////////////////////////////
 
 class NotificationCenterButton : public views::TextButton {
  public:
   NotificationCenterButton(views::ButtonListener* listener,
                            const string16& text);
 
- protected:

[dharcourt, 2013/04/17 21:58:56]

"protected:" should be moved down two lines instead of removed because while
GetPreferredSize() is public, OnPaintBorder() and OnPaintFocusBorder() should be
protected.

[Jun Mukai, 2013/04/18 18:16:44]

Done.

   // Overridden from views::View:
   virtual gfx::Size GetPreferredSize() OVERRIDE;
   virtual void OnPaintBorder(gfx::Canvas* canvas);
   virtual void OnPaintFocusBorder(gfx::Canvas* canvas);

[dharcourt, 2013/04/17 21:58:56]

I know this is preexisting, but shouldn't OnPaintBorder() and OnFocusBorder()
have OVERRIDEs?

[Jun Mukai, 2013/04/18 18:16:44]

Done.

 
+ private:
   DISALLOW_COPY_AND_ASSIGN(NotificationCenterButton);
 };
 
 NotificationCenterButton::NotificationCenterButton(
     views::ButtonListener* listener,
     const string16& text)
     : views::TextButton(listener, text) {
   set_border(views::Border::CreateEmptyBorder(0, 16, 0, 16));
   set_min_height(kFooterHeight);
   SetEnabledColor(kFooterTextColor);
@@ skipping 33 matching lines @@
 
  private:
   // Overridden from views::View:
   virtual void ChildVisibilityChanged(views::View* child) OVERRIDE;
 
   // Overridden from views::ButtonListener:
   virtual void ButtonPressed(views::Button* sender,
                              const ui::Event& event) OVERRIDE;
 
   views::Label* notification_label_;
-  views::Button* settings_button_;
+  NotificationCenterButton* settings_button_;
 
   DISALLOW_COPY_AND_ASSIGN(RichMessageCenterButtonBar);
 };
 
 RichMessageCenterButtonBar::RichMessageCenterButtonBar(
     MessageCenter* message_center)
   : MessageCenterButtonBar(message_center) {
   set_background(views::Background::CreateSolidBackground(
       kMessageCenterBackgroundColor));
   set_border(views::Border::CreateSolidSidedBorder(
       1, 0, 0, 0, kFooterDelimiterColor));
 
 
   notification_label_ = new views::Label(l10n_util::GetStringUTF16(
       IDS_MESSAGE_CENTER_FOOTER_TITLE));
   notification_label_->SetHorizontalAlignment(gfx::ALIGN_LEFT);
   notification_label_->SetElideBehavior(views::Label::ELIDE_AT_END);
   notification_label_->SetEnabledColor(kFooterTextColor);
   AddChildView(notification_label_);
   settings_button_ = new NotificationCenterButton(
       this, l10n_util::GetStringUTF16(
           IDS_MESSAGE_CENTER_SETTINGS_BUTTON_LABEL));
   settings_button_->set_focusable(true);
+  settings_button_->set_request_focus_on_press(false);
   AddChildView(settings_button_);
   NotificationCenterButton* close_all_button = new NotificationCenterButton(
       this, l10n_util::GetStringUTF16(IDS_MESSAGE_CENTER_CLEAR_ALL));
   close_all_button->set_focusable(true);
+  close_all_button->set_request_focus_on_press(false);
   AddChildView(close_all_button);
 
   views::GridLayout* layout = new views::GridLayout(this);
   SetLayoutManager(layout);
   layout->SetInsets(
       kMarginBetweenItems, kFooterMargin, kMarginBetweenItems, 0);
   views::ColumnSet* column = layout->AddColumnSet(0);
   column->AddColumn(views::GridLayout::FILL, views::GridLayout::FILL,
                     1.0f, views::GridLayout::USE_PREF, 0, 0);
   column->AddColumn(views::GridLayout::LEADING, views::GridLayout::FILL,
@@ skipping 237 matching lines @@
   // NotificationViews are expanded by default here until
   // http://crbug.com/217902 is fixed. TODO(dharcourt): Fix.
   MessageView* view = NotificationView::Create(
       notification, message_center_, true);
   view->set_scroller(scroller_);
   message_views_[notification.id()] = view;
   message_list_view_->AddChildView(view);
 }
 
 }  // namespace message_center