History: Reload page only after web history deletion has completed.

History: Reload page only after web history deletion has completed.

When history sync is enabled, deletions need to be done in both the
history DB and on the history server. Wait until the request to the
server has completed before reloading the page, otherwise it can
appear that the deletion did not take effect.

BUG=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195140

[Patrick Dubroy, 2013-04-17 16:51:29]

James, please take a look.

[James Hawkins, 2013-04-17 16:59:25]

https://codereview.chromium.org/14225004/diff/2001/chrome/browser/history/web...
File chrome/browser/history/web_history_service.cc (right):

https://codereview.chromium.org/14225004/diff/2001/chrome/browser/history/web...
chrome/browser/history/web_history_service.cc:128: is_pending_ = false;
This seems fragile.  Can we not use callback_ somehow, like callback_.hasRun (I
don't remember what the exact syntax is)?

[Patrick Dubroy, 2013-04-17 19:15:52]

On 2013/04/17 16:59:25, James Hawkins wrote:
>
https://codereview.chromium.org/14225004/diff/2001/chrome/browser/history/web...
> File chrome/browser/history/web_history_service.cc (right):
> 
>
https://codereview.chromium.org/14225004/diff/2001/chrome/browser/history/web...
> chrome/browser/history/web_history_service.cc:128: is_pending_ = false;
> This seems fragile.  Can we not use callback_ somehow, like callback_.hasRun
(I
> don't remember what the exact syntax is)?

I don't think so. Callbacks can be run more than once:
https://code.google.com/p/chromium/codesearch#chromium/src/base/callback.h&l=87.

[James Hawkins, 2013-04-17 20:01:13]

On 2013/04/17 19:15:52, dubroy wrote:
> On 2013/04/17 16:59:25, James Hawkins wrote:
> >
>
https://codereview.chromium.org/14225004/diff/2001/chrome/browser/history/web...
> > File chrome/browser/history/web_history_service.cc (right):
> > 
> >
>
https://codereview.chromium.org/14225004/diff/2001/chrome/browser/history/web...
> > chrome/browser/history/web_history_service.cc:128: is_pending_ = false;
> > This seems fragile.  Can we not use callback_ somehow, like callback_.hasRun
> (I
> > don't remember what the exact syntax is)?
> 
> I don't think so. Callbacks can be run more than once:
>
https://code.google.com/p/chromium/codesearch#chromium/src/base/callback.h&l=87.

bummer.

LGTM

[Patrick Dubroy, 2013-04-19 12:48:25]

Committed patchset #1 manually as r195140 (presubmit successful).