content/browser/download/save_package.h - Issue 1422473004: Vector-of-structs (instead of struct-of-vectors) in "savable resources" IPC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/save_package.h

Issue 1422473004: Vector-of-structs (instead of struct-of-vectors) in "savable resources" IPC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@page-serialization-original-url-yay

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/download/save_package.h

diff --git a/content/browser/download/save_package.h b/content/browser/download/save_package.h

index 4e02c1fa5f43ac5b3e06adfbc9286c5d9382f8b7..d95018105e8144a140b17d4b67f063dfa6490c2e 100644

--- a/content/browser/download/save_package.h

+++ b/content/browser/download/save_package.h

@@ -34,6 +34,7 @@ namespace content {

class DownloadItemImpl;

class DownloadManagerImpl;

class RenderFrameHostImpl;

+struct SavableSubframe;

class SaveFileManager;

class SaveItem;

class SavePackage;

@@ -186,8 +187,7 @@ class CONTENT_EXPORT SavePackage

RenderFrameHostImpl* sender,

const std::vector<GURL>& resources_list,

const std::vector<Referrer>& referrers_list,

- const std::vector<GURL>& subframe_original_urls,

- const std::vector<int>& subframe_routing_ids);

+ const std::vector<SavableSubframe>& subframes);

SaveItem* FindOrCreatePendingSaveItem(

int container_frame_tree_node_id,

const GURL& url,

« no previous file with comments | « no previous file | content/browser/download/save_package.cc » ('j') | content/common/frame_messages.h » ('J')