Vector-of-structs (instead of struct-of-vectors) in "savable resources" IPC.

content/browser/download/save_package.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/download/save_package.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/files/file_path.h"
@@ skipping 1194 matching lines @@
 
 void SavePackage::GetSavableResourceLinksForFrame(RenderFrameHost* target) {
   number_of_frames_pending_response_++;
   target->Send(new FrameMsg_GetSavableResourceLinks(target->GetRoutingID()));
 }
 
 void SavePackage::OnSavableResourceLinksResponse(
     RenderFrameHostImpl* sender,
     const std::vector<GURL>& resources_list,
     const Referrer& referrer,
-    const std::vector<GURL>& subframe_original_urls,
-    const std::vector<int>& subframe_routing_ids) {
+    const std::vector<SavableSubframe>& subframes) {
   if (wait_state_ != RESOURCES_LIST)
     return;
 
-  if (subframe_original_urls.size() != subframe_routing_ids.size()) {
-    // Only reachable if the renderer has a bug or has been compromised.
-    NOTREACHED();
-    return;
-  }
-
   // Add all sub-resources to wait list.
   int container_frame_tree_node_id =
       sender->frame_tree_node()->frame_tree_node_id();
   for (const GURL& u : resources_list) {
     EnqueueSavableResource(container_frame_tree_node_id, u, referrer);
   }
-  for (size_t i = 0; i < subframe_routing_ids.size(); ++i) {
+  for (const SavableSubframe& subframe : subframes) {
     FrameTreeNode* subframe_tree_node =
         sender->frame_tree_node()->frame_tree()->FindByRoutingID(
-            sender->GetProcess()->GetID(), subframe_routing_ids[i]);
+            sender->GetProcess()->GetID(), subframe.routing_id);
 
     if (!subframe_tree_node ||
         subframe_tree_node->parent() != sender->frame_tree_node()) {
       // Only reachable if the renderer has a bug or has been compromised.
       NOTREACHED();
       continue;
     }
 
     EnqueueFrame(container_frame_tree_node_id,
                  subframe_tree_node->frame_tree_node_id(),
-                 subframe_original_urls[i]);
+                 subframe.original_url);
   }
 
   CompleteSavableResourceLinksResponse();
 }
 
 SaveItem* SavePackage::FindOrCreatePendingSaveItem(
     int container_frame_tree_node_id,
     const GURL& url,
     const Referrer& referrer,
     SaveFileCreateInfo::SaveFileSource save_source) {
@@ skipping 318 matching lines @@
 
 void SavePackage::FinalizeDownloadEntry() {
   DCHECK(download_);
   DCHECK(download_manager_);
 
   download_manager_->OnSavePackageSuccessfullyFinished(download_);
   StopObservation();
 }
 
 }  // namespace content