Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 1422473003: Document truncating behavior of typed_data lists. (Closed)

Created:
5 years, 1 month ago by Lasse Reichstein Nielsen
Modified:
5 years, 1 month ago
Reviewers:
floitsch, sra1
CC:
reviews_dartlang.org, floitsch
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -12 lines) Patch
M sdk/lib/typed_data/typed_data.dart View 1 20 chunks +51 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Lasse Reichstein Nielsen
5 years, 1 month ago (2015-10-28 10:08:31 UTC) #2
floitsch
LGTM. https://codereview.chromium.org/1422473003/diff/1/sdk/lib/typed_data/typed_data.dart File sdk/lib/typed_data/typed_data.dart (right): https://codereview.chromium.org/1422473003/diff/1/sdk/lib/typed_data/typed_data.dart#newcode741 sdk/lib/typed_data/typed_data.dart:741: * the same way storing values will truncate ...
5 years, 1 month ago (2015-10-28 10:32:09 UTC) #4
sra1
lgtm. I prefer Florian's wording.
5 years, 1 month ago (2015-10-28 20:25:01 UTC) #5
Lasse Reichstein Nielsen
https://codereview.chromium.org/1422473003/diff/1/sdk/lib/typed_data/typed_data.dart File sdk/lib/typed_data/typed_data.dart (right): https://codereview.chromium.org/1422473003/diff/1/sdk/lib/typed_data/typed_data.dart#newcode741 sdk/lib/typed_data/typed_data.dart:741: * the same way storing values will truncate them. ...
5 years, 1 month ago (2015-10-29 08:56:00 UTC) #6
Lasse Reichstein Nielsen
5 years, 1 month ago (2015-10-29 08:56:08 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0172094a500e0043fadc50df3042ad345f4ec904 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698