Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1422463013: Allow disabling warnings as errors in GN (Closed)

Created:
5 years, 1 month ago by Paweł Hajdan Jr.
Modified:
5 years, 1 month ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow disabling warnings as errors in GN See https://groups.google.com/a/chromium.org/d/msg/gn-dev/_kL9GvezAk4/eE2P2TB5AgAJ for context. BUG=551343 Committed: https://crrev.com/1c8d4b99485d92b973a67a5f9fcd253fb1b6bf2b Cr-Commit-Position: refs/heads/master@{#358801}

Patch Set 1 #

Total comments: 2

Patch Set 2 : windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M build/config/compiler/BUILD.gn View 1 3 chunks +13 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Paweł Hajdan Jr.
5 years, 1 month ago (2015-11-06 10:17:56 UTC) #2
Dirk Pranke
https://codereview.chromium.org/1422463013/diff/1/build/config/compiler/BUILD.gn File build/config/compiler/BUILD.gn (right): https://codereview.chromium.org/1422463013/diff/1/build/config/compiler/BUILD.gn#newcode719 build/config/compiler/BUILD.gn:719: cflags += [ "-Werror" ] Does it make sense ...
5 years, 1 month ago (2015-11-06 17:56:54 UTC) #3
brettw
https://codereview.chromium.org/1422463013/diff/1/build/config/compiler/BUILD.gn File build/config/compiler/BUILD.gn (right): https://codereview.chromium.org/1422463013/diff/1/build/config/compiler/BUILD.gn#newcode719 build/config/compiler/BUILD.gn:719: cflags += [ "-Werror" ] Yeah, it makes sense ...
5 years, 1 month ago (2015-11-09 02:25:03 UTC) #5
Paweł Hajdan Jr.
Done, PTAL.
5 years, 1 month ago (2015-11-09 16:08:03 UTC) #6
Dirk Pranke
lgtm
5 years, 1 month ago (2015-11-09 20:31:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1422463013/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1422463013/20001
5 years, 1 month ago (2015-11-10 07:21:48 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-10 07:26:03 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 07:26:36 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/1c8d4b99485d92b973a67a5f9fcd253fb1b6bf2b
Cr-Commit-Position: refs/heads/master@{#358801}

Powered by Google App Engine
This is Rietveld 408576698