third_party/WebKit/Source/platform/graphics/Color.cpp - Issue 1422453005: Get VS 2015 to use const int definitions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/Color.cpp

Issue 1422453005: Get VS 2015 to use const int definitions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update README.chromium Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/graphics/Color.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/Color.cpp b/third_party/WebKit/Source/platform/graphics/Color.cpp

index 195e7f60fab0292d6fc229eddfd8c4c27ff719bb..3bce2cc162277667e6bcfcad4fc817a5fa797488 100644

--- a/third_party/WebKit/Source/platform/graphics/Color.cpp

+++ b/third_party/WebKit/Source/platform/graphics/Color.cpp

@@ -35,7 +35,8 @@

namespace blink {

-#if !COMPILER(MSVC)

+// VS 2015 and above allow these definitions and in this case require them

+#if !COMPILER(MSVC) || _MSC_VER >= 1900

// FIXME: Use C++11 strong enums to avoid static data member with initializer definition problems.

const RGBA32 Color::black;

const RGBA32 Color::white;

« no previous file with comments | « no previous file | third_party/protobuf/README.chromium » ('j') | no next file with comments »