Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1422453002: Fix windows build (Closed)

Created:
5 years, 2 months ago by srdjan
Modified:
5 years, 2 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M runtime/vm/isolate.h View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/stack_frame.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
srdjan
5 years, 2 months ago (2015-10-20 20:50:55 UTC) #2
srdjan
Canceling this fix, as John is submitting the proper one.
5 years, 2 months ago (2015-10-20 20:57:55 UTC) #3
srdjan
On 2015/10/20 20:57:55, srdjan wrote: > Canceling this fix, as John is submitting the proper ...
5 years, 2 months ago (2015-10-20 21:14:09 UTC) #4
Cutch
lgtm
5 years, 2 months ago (2015-10-20 21:16:26 UTC) #5
srdjan
5 years, 2 months ago (2015-10-20 21:23:15 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
769119b067d8c1e0ed449c62a02d65fee644382e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698