Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1422443006: [Intepreter] Don't throw reference errors for globals in typeof. (Closed)

Created:
5 years, 1 month ago by rmcilroy
Modified:
5 years, 1 month ago
Reviewers:
Benedikt Meurer, oth
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Intepreter] Don't throw reference errors for globals in typeof. Corrects LdaGlobal to deal with TypeofMode::INSIDE_TYPEOF so that it doesn't throw a reference error on undefined globals. BUG=v8:4280 LOG=N Committed: https://crrev.com/6eb5dae5361773597723dca88e95208dac0b93fe Cr-Commit-Position: refs/heads/master@{#31757}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+213 lines, -63 lines) Patch
M src/compiler/bytecode-graph-builder.cc View 2 chunks +24 lines, -0 lines 0 comments Download
M src/interpreter/bytecode-array-builder.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 1 3 chunks +17 lines, -6 lines 0 comments Download
M src/interpreter/bytecode-generator.h View 1 chunk +8 lines, -5 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 4 chunks +17 lines, -9 lines 0 comments Download
M src/interpreter/bytecodes.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/interpreter/interpreter.cc View 2 chunks +48 lines, -0 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 1 2 chunks +67 lines, -13 lines 0 comments Download
M test/cctest/interpreter/test-interpreter.cc View 1 1 chunk +15 lines, -24 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-builder-unittest.cc View 1 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1422443006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1422443006/1
5 years, 1 month ago (2015-11-03 11:01:29 UTC) #2
rmcilroy
Orion, PTAL at the interpreter/ changes. Benedikt, PTAL at the compiler/ changes. Thanks.
5 years, 1 month ago (2015-11-03 11:01:51 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-03 11:22:26 UTC) #6
Benedikt Meurer
LGTM on compiler.
5 years, 1 month ago (2015-11-03 11:25:38 UTC) #7
oth
lgtm for interpreter and tests.
5 years, 1 month ago (2015-11-03 14:02:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1422443006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1422443006/1
5 years, 1 month ago (2015-11-03 14:32:55 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/7351)
5 years, 1 month ago (2015-11-03 14:35:07 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1422443006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1422443006/20001
5 years, 1 month ago (2015-11-03 16:44:30 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-03 17:03:32 UTC) #16
commit-bot: I haz the power
5 years, 1 month ago (2015-11-03 17:03:45 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6eb5dae5361773597723dca88e95208dac0b93fe
Cr-Commit-Position: refs/heads/master@{#31757}

Powered by Google App Engine
This is Rietveld 408576698