Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 1422443004: X87: VectorICs: use a vector slot to aid in array literal processing. (Closed)

Created:
5 years, 2 months ago by zhengxing.li
Modified:
5 years, 2 months ago
Reviewers:
Weiliang, chunyang.dai
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: VectorICs: use a vector slot to aid in array literal processing. port f2f46aff8b776365e0bafd7826f23c8b9c16d928 (r31242). original commit message: The lack of a vector slot for the keyed store operation in filling in non-constant array literal properties led to undesirable contortions in compilers downwind of full-codegen. The use of a single slot to initialize all the array elements is sufficient. BUG= Committed: https://crrev.com/9826a77f33467fb741ac7277888a49f56c0e7858 Cr-Commit-Position: refs/heads/master@{#31505}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
zhengxing.li
5 years, 2 months ago (2015-10-23 09:09:21 UTC) #2
Weiliang
lgtm
5 years, 2 months ago (2015-10-23 09:11:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1422443004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1422443004/1
5 years, 2 months ago (2015-10-23 09:11:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-23 10:04:51 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 10:05:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9826a77f33467fb741ac7277888a49f56c0e7858
Cr-Commit-Position: refs/heads/master@{#31505}

Powered by Google App Engine
This is Rietveld 408576698