Fix presubmit.py tests.

app_test.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import ast
 import datetime
 import hashlib
 import hmac
 import json
@@ skipping 197 matching lines @@
     self.save_page(localpath='chromium/sheriff_cros_nonmtv.js',
                    content='document.write(\'sheriff8\')')
     input_console = self._load_content(test_dir, 'console-input.html')
     expected_console = self._load_content(test_dir, 'console-expected.html')
     page_data = {'content': input_console}
     actual_console = app.console_handler(
         unquoted_localpath='chromium/console',
         remoteurl='http://build.chromium.org/p/chromium/console',
         page_data=page_data)
     # Uncomment if deeper inspection is needed of the returned console.
+    # This is also useful if changing the site layout and you need to
+    # 'retrain' the test expectations.

[cmp, 2014/01/18 01:46:07]

Thanks for commenting this.  It was actually the main reason I kept this code
around, so +1.

     # with open(os.path.join(test_dir, 'console-expected.html'), 'w') as fh:
     #   fh.write(actual_console['content'])
     self.assertEquals(expected_console, actual_console['content'],
                       'Unexpected console output found')
 
   def test_console_handler_utf8(self):
     test_dir = os.path.join(TEST_DIR, 'test_console_handler_utf8')
     self.save_page(localpath='chromium/sheriff.js',
                    content='document.write(\'sheriff1\')')
     self.save_page(localpath='chromium/sheriff_webkit.js',
                    content='document.write(\'sheriff2\')')
     self.save_page(localpath='chromium/sheriff_memory.js',
                    content='document.write(\'sheriff3\')')
     self.save_page(localpath='chromium/sheriff_nacl.js',
                    content='document.write(\'sheriff4\')')
     self.save_page(localpath='chromium/sheriff_perf.js',
                    content='document.write(\'sheriff5\')')
     self.save_page(localpath='chromium/sheriff_cros_mtv.js',
                    content='document.write(\'sheriff6, sheriff7\')')
     self.save_page(localpath='chromium/sheriff_cros_nonmtv.js',
                    content='document.write(\'sheriff8\')')
     input_console = self._load_content(test_dir, 'console-input.html')
     expected_console = self._load_content(test_dir, 'console-expected.html')
     page_data = {'content': input_console}
     actual_console = app.console_handler(
         unquoted_localpath='chromium/console',
         remoteurl='http://build.chromium.org/p/chromium/console',
         page_data=page_data)
     # Uncomment if deeper inspection is needed of the returned console.
+    # This is also useful if changing the site layout and you need to
+    # 'retrain' the test expectations.
     # with open(os.path.join(test_dir, 'console-expected.html'), 'w') as fh:
     #   fh.write(actual_console['content'])
     self.assertEquals(expected_console, actual_console['content'],
                       'Unexpected console output found')
 
   def test_parse_master(self):
     test_dir = os.path.join(TEST_DIR, 'test_parse_master')
     expected_rev = self._load_content(test_dir, 'expected-rev.html').strip()
     expected_name = self._load_content(test_dir, 'expected-name.html').strip()
     expected_status = self._load_content(test_dir,
@@ skipping 185 matching lines @@
       return fr
 
     expected_content = self._load_content(test_dir, 'expected.html')
     app.fetch_page(
         localpath='chromium/console',
         remoteurl='http://build.chromium.org/p/chromium/console',
         maxage=0,
         fetch_url=fetch_url)
     page = app.get_and_cache_pagedata('chromium/console')
     # Uncomment if deeper inspection is needed of the returned console.
+    # This is also useful if changing the site layout and you need to
+    # 'retrain' the test expectations.
     # with open(os.path.join(test_dir, 'expected.html'), 'w') as fh:
     #   fh.write(page['content'])
     self.assertEquals(expected_content, page['content'])
 
   def test_fetch_console(self):
     test_dir = os.path.join(TEST_DIR, 'test_fetch_console')
 
     def fetch_url(url):
       fr = FetchTestCase.FakeResponse()
       if url == 'http://build.chromium.org/p/chromium/console':
         fr.content = self._load_content(test_dir, 'input.html')
       return fr
 
     expected_content = self._load_content(test_dir, 'expected.html')
     app.fetch_page(
         localpath='chromium/console',
         remoteurl='http://build.chromium.org/p/chromium/console',
         maxage=0,
         postfetch=app.console_handler,
         fetch_url=fetch_url)
     page = app.get_and_cache_pagedata('chromium/console')
     # Uncomment if deeper inspection is needed of the returned console.
+    # This is also useful if changing the site layout and you need to
+    # 'retrain' the test expectations.
     # with open(os.path.join(test_dir, 'expected.html'), 'w') as fh:
     #   fh.write(page['content'])
     self.assertEquals('interface', page['body_class'])
     self.assertEquals(expected_content, page['content'])
     self.assertEquals(
         'http://build.chromium.org/p/chromium/console/../',
         page['offsite_base'])
     self.assertEquals('BuildBot: Chromium', page['title'])
 
 
@@ skipping 59 matching lines @@
     ]
 
     for test_json in tests:
       # pylint: disable=W0212
       self.assertFalse(Email._validate_message(test_json, url, secret))
 
     test_json = self._hash_message(time.time(), message, url, secret)
     test_json['message'] = test_json['message'] + 'hey'
     # pylint: disable=W0212
     self.assertFalse(Email._validate_message(test_json, url, secret))