Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1422423003: Revert of Avoid rendering using GL in case damage rect is composited by overlay (Closed)

Created:
5 years, 1 month ago by ccameron
Modified:
5 years, 1 month ago
Reviewers:
kalyank, piman
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Avoid rendering using GL in case damage rect is composited by overlay (patchset #4 id:60001 of https://codereview.chromium.org/1413763013/ ) Reason for revert: This conflicts with reverting https://codereview.chromium.org/1330563004 Which broke YouTube on Mac BUG=549350 Original issue's description: > Avoid rendering using GL in case damage rect is composited by overlay > > We can avoid drawing using GL if the damage rect is entirely > composited by using overlays. > > BUG=370522 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/7c024b25d977484b627b63bff9f85e5b5e382b9e > Cr-Commit-Position: refs/heads/master@{#356844} TBR=piman@chromium.org,kalyan.kondapally@intel.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=370522 Committed: https://crrev.com/e6f555ea4ea574dfd491690e07f9a79ac3a9f591 Cr-Commit-Position: refs/heads/master@{#357221}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -60 lines) Patch
M cc/output/direct_renderer.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M cc/output/overlay_unittest.cc View 2 chunks +4 lines, -41 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ccameron
Created Revert of Avoid rendering using GL in case damage rect is composited by overlay
5 years, 1 month ago (2015-10-30 23:26:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1422423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1422423003/1
5 years, 1 month ago (2015-10-30 23:27:29 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 23:29:08 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 23:30:00 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e6f555ea4ea574dfd491690e07f9a79ac3a9f591
Cr-Commit-Position: refs/heads/master@{#357221}

Powered by Google App Engine
This is Rietveld 408576698