src/hydrogen.cc - Issue 14224009: Replace instance type check for polymorphic array.length with map check

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen.cc

Issue 14224009: Replace instance type check for polymorphic array.length with map check (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Remove spurious change Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/hydrogen.cc

diff --git a/src/hydrogen.cc b/src/hydrogen.cc

index a2ddc04b9174f2ec7b95f68acd3acd199ee0a848..bf34014f62c74d182324730d6f77cba73f61d85c 100644

--- a/src/hydrogen.cc

+++ b/src/hydrogen.cc

@@ -6566,8 +6566,9 @@ bool HOptimizedGraphBuilder::HandlePolymorphicArrayLengthLoad(

}

AddInstruction(new(zone()) HCheckNonSmi(object));

HInstruction* typecheck =

- AddInstruction(HCheckInstanceType::NewIsJSArray(object, zone()));

+ AddInstruction(new(zone()) HCheckMaps(object, types, zone()));

HInstruction* instr =

HLoadNamedField::NewArrayLength(zone(), object, typecheck);

instr->set_position(expr->position());

« no previous file with comments | « no previous file | no next file » | no next file with comments »