Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Issue 14224009: Replace instance type check for polymorphic array.length with map check (Closed)

Created:
7 years, 8 months ago by Dmitry Lomov (no reviews)
Modified:
7 years, 8 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Homogenizes map checks for all polymorphic named field loads. Tests show no perf regressions BUG= Committed: https://code.google.com/p/v8/source/detail?r=14259

Patch Set 1 #

Patch Set 2 : Remove spurious change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/hydrogen.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Dmitry Lomov (no reviews)
PTAL
7 years, 8 months ago (2013-04-15 07:20:24 UTC) #1
Toon Verwaest
lgtm
7 years, 8 months ago (2013-04-15 09:00:53 UTC) #2
Dmitry Lomov (no reviews)
7 years, 8 months ago (2013-04-15 09:06:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r14259 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698