Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 1422363004: [CacheStorage] Give cache directories unique names (Closed)

Created:
5 years, 1 month ago by jkarlin
Modified:
5 years, 1 month ago
Reviewers:
CC:
chromium-reviews, asanka, benjhayden+dwatch_chromium.org, jam, nhiroki, darin-cc_chromium.org, jkarlin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2526
Target Ref:
refs/pending/branch-heads/2526
Project:
chromium
Visibility:
Public.

Description

[CacheStorage] Give cache directories unique names The CacheStorage class creates a directory for each cache based off of a hash of the cache's name. This is problematic in situations where a cache is deleted and then recreated (but not yet wiped from disk as javascript might be referencing it). This CL gives every new cache a unique directory and stores the directory mapping in the cache storage index protobuf. Legacy caches are moved to new directories on CacheStorage initialization. BUG=542668 TBR=jochen, jsbell There are two CLs in this merge as the second fixes a bug in the first. Review URL: https://codereview.chromium.org/1414033002 Review URL: https://codereview.chromium.org/1428463002 Cr-Commit-Position: refs/heads/master@{#356055} (cherry picked from commit 4519a22b4c1683f1e79543a4238bc5cdb1880b5e) Cr-Commit-Position: refs/heads/master@{#356107} (cherry picked from commit b65cfea2a48ce74ac98e2b10006e9d8b868d4553) Committed: https://chromium.googlesource.com/chromium/src/+/26e40aa877846f7208e63860728fff703c40a122

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+286 lines, -69 lines) Patch
M content/browser/cache_storage/cache_storage.cc View 11 chunks +120 lines, -65 lines 0 comments Download
M content/browser/cache_storage/cache_storage.proto View 1 chunk +4 lines, -1 line 0 comments Download
M content/browser/cache_storage/cache_storage_cache.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/cache_storage/cache_storage_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/cache_storage/cache_storage_manager_unittest.cc View 9 chunks +157 lines, -3 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
jkarlin
5 years, 1 month ago (2015-11-02 14:00:25 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
26e40aa877846f7208e63860728fff703c40a122 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698