Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: content/renderer/render_frame_impl.h

Issue 1422333009: OOPIF: History navigations for new child frames. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Improve comment. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/frame_messages.h ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.h
diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h
index e972282cdde4253aad6f75df8b89797c161d0547..374e09da4cc2ee365a7f7427458e6294badf2c7f 100644
--- a/content/renderer/render_frame_impl.h
+++ b/content/renderer/render_frame_impl.h
@@ -450,8 +450,7 @@ class CONTENT_EXPORT RenderFrameImpl
bool should_replace_current_entry) override;
blink::WebNavigationPolicy decidePolicyForNavigation(
const NavigationPolicyInfo& info) override;
- blink::WebHistoryItem historyItemForNewChildFrame(
- blink::WebFrame* frame) override;
+ blink::WebHistoryItem historyItemForNewChildFrame() override;
void willSendSubmitEvent(blink::WebLocalFrame* frame,
const blink::WebFormElement& form) override;
void willSubmitForm(blink::WebLocalFrame* frame,
@@ -772,10 +771,15 @@ class CONTENT_EXPORT RenderFrameImpl
std::vector<base::FilePath> equivalent_local_paths,
base::FilePath local_directory_path);
+ // Requests that the browser process navigates to |url|. If
+ // |is_history_navigation_in_new_child| is true, the browser process should
+ // look for a matching FrameNavigationEntry in the last committed entry to use
+ // instead of |url|.
void OpenURL(const GURL& url,
const Referrer& referrer,
blink::WebNavigationPolicy policy,
- bool should_replace_current_entry);
+ bool should_replace_current_entry,
+ bool is_history_navigation_in_new_child);
// Performs a navigation in the frame. This provides a unified function for
// the current code path and the browser-side navigation path (in
« no previous file with comments | « content/common/frame_messages.h ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698