Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Unified Diff: content/browser/frame_host/navigation_entry_impl.h

Issue 1422333009: OOPIF: History navigations for new child frames. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Improve comment. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_entry_impl.h
diff --git a/content/browser/frame_host/navigation_entry_impl.h b/content/browser/frame_host/navigation_entry_impl.h
index 051a3ba909f524b31fa1385bbff4774379f73c74..8d97ef39871055859583b4c36a48b7e4d78c0423 100644
--- a/content/browser/frame_host/navigation_entry_impl.h
+++ b/content/browser/frame_host/navigation_entry_impl.h
@@ -192,6 +192,15 @@ class CONTENT_EXPORT NavigationEntryImpl
// there is one in this NavigationEntry.
FrameNavigationEntry* GetFrameEntry(FrameTreeNode* frame_tree_node) const;
+ // Returns the FrameNavigationEntry corresponding to the frame with the given
+ // |unique_name|, if any. This is useful when the FrameTreeNode cannot be used
+ // to find the entry, such as for a newly created subframe in a history
+ // navigation. Callers should update the FrameTreeNode ID of the entry so that
+ // it can be found with |GetFrameEntry| above.
+ // TODO(creis): Generate or verify the unique_name in the browser process.
+ FrameNavigationEntry* GetFrameEntryByUniqueName(
+ const std::string& unique_name) const;
+
void set_unique_id(int unique_id) {
unique_id_ = unique_id;
}
« no previous file with comments | « content/browser/frame_host/navigation_controller_impl_unittest.cc ('k') | content/browser/frame_host/navigation_entry_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698