Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: third_party/WebKit/public/web/WebFrameClient.h

Issue 1422333009: OOPIF: History navigations for new child frames. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Better DidStartLoading fix, disable restore test Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/web/WebFrameClient.h
diff --git a/third_party/WebKit/public/web/WebFrameClient.h b/third_party/WebKit/public/web/WebFrameClient.h
index fe84a47512db8374cb459984c4ad808d4f73ceb5..6fab57d85edef8e47c5cb0a4aaa166df92ebe257 100644
--- a/third_party/WebKit/public/web/WebFrameClient.h
+++ b/third_party/WebKit/public/web/WebFrameClient.h
@@ -237,8 +237,9 @@ public:
}
// During a history navigation, we may choose to load new subframes from history as well.
- // This returns such a history item if appropriate.
- virtual WebHistoryItem historyItemForNewChildFrame(WebFrame*) { return WebHistoryItem(); }
+ // This returns such a history item if appropriate. Sets shouldLoadRequest to false if
+ // the history item will be handled asynchronously.
+ virtual WebHistoryItem historyItemForNewChildFrame(bool* shouldLoadRequest) { return WebHistoryItem(); }
// Whether the client is handling a navigation request.
virtual bool hasPendingNavigation(WebLocalFrame*) { return false; }

Powered by Google App Engine
This is Rietveld 408576698