Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Side by Side Diff: runtime/vm/raw_object.h

Issue 142233002: Make sure all new Code objects have a non-null PcDescriptors (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« runtime/vm/object.cc ('K') | « runtime/vm/object.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_RAW_OBJECT_H_ 5 #ifndef VM_RAW_OBJECT_H_
6 #define VM_RAW_OBJECT_H_ 6 #define VM_RAW_OBJECT_H_
7 7
8 #include "platform/assert.h" 8 #include "platform/assert.h"
9 #include "vm/globals.h" 9 #include "vm/globals.h"
10 #include "vm/token.h" 10 #include "vm/token.h"
(...skipping 872 matching lines...) Expand 10 before | Expand all | Expand 10 after
883 }; 883 };
884 884
885 885
886 class RawPcDescriptors : public RawObject { 886 class RawPcDescriptors : public RawObject {
887 RAW_HEAP_OBJECT_IMPLEMENTATION(PcDescriptors); 887 RAW_HEAP_OBJECT_IMPLEMENTATION(PcDescriptors);
888 888
889 RawSmi* length_; // Number of descriptors. 889 RawSmi* length_; // Number of descriptors.
890 890
891 // Variable length data follows here. 891 // Variable length data follows here.
892 intptr_t data_[0]; 892 intptr_t data_[0];
893
894 friend class Object;
893 }; 895 };
894 896
895 897
896 // Stackmap is an immutable representation of the layout of the stack at a 898 // Stackmap is an immutable representation of the layout of the stack at a
897 // PC. The stack map representation consists of a bit map which marks each 899 // PC. The stack map representation consists of a bit map which marks each
898 // live object index starting from the base of the frame. 900 // live object index starting from the base of the frame.
899 // 901 //
900 // The Stackmap also consists of a link to the code object corresponding to 902 // The Stackmap also consists of a link to the code object corresponding to
901 // the frame which the stack map is describing. The bit map representation 903 // the frame which the stack map is describing. The bit map representation
902 // is optimized for dense and small bit maps, without any upper bound. 904 // is optimized for dense and small bit maps, without any upper bound.
(...skipping 837 matching lines...) Expand 10 before | Expand all | Expand 10 after
1740 // Make sure this is updated when new TypedData types are added. 1742 // Make sure this is updated when new TypedData types are added.
1741 ASSERT(kTypedDataInt8ArrayViewCid == kTypedDataInt8ArrayCid + 13); 1743 ASSERT(kTypedDataInt8ArrayViewCid == kTypedDataInt8ArrayCid + 13);
1742 ASSERT(kExternalTypedDataInt8ArrayCid == kTypedDataInt8ArrayViewCid + 14); 1744 ASSERT(kExternalTypedDataInt8ArrayCid == kTypedDataInt8ArrayViewCid + 14);
1743 ASSERT(kNullCid == kExternalTypedDataInt8ArrayCid + 13); 1745 ASSERT(kNullCid == kExternalTypedDataInt8ArrayCid + 13);
1744 return (kNullCid - kTypedDataInt8ArrayCid); 1746 return (kNullCid - kTypedDataInt8ArrayCid);
1745 } 1747 }
1746 1748
1747 } // namespace dart 1749 } // namespace dart
1748 1750
1749 #endif // VM_RAW_OBJECT_H_ 1751 #endif // VM_RAW_OBJECT_H_
OLDNEW
« runtime/vm/object.cc ('K') | « runtime/vm/object.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698