dart2js: use WorldImpact for dump_info

dart2js: use WorldImpact for dump_info

BUG=
R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/0df916cce0754b090fab72e51ffdaf2dd4d0e670

[Harry Terkelsen, 2015-11-12 01:02:56]

het@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2015-11-12 01:11:00]

nice! Looking forward to see the difference with this.

lgtm, although it would be nice if we can address the caching issue together
with this CL (unless there are other uses planned for the impacts in world)

https://codereview.chromium.org/1422323007/diff/40001/pkg/compiler/lib/src/en...
File pkg/compiler/lib/src/enqueue.dart (right):

https://codereview.chromium.org/1422323007/diff/40001/pkg/compiler/lib/src/en...
pkg/compiler/lib/src/enqueue.dart:892: final Map<Element, WorldImpact> impacts =
<Element, WorldImpact>{};
since this is only used by dump-info, how about storing this directly in the
dumpinfo task, and only set it conditionally when dump info is enabled (that way
we save the space when it is not)

https://codereview.chromium.org/1422323007/diff/40001/pkg/compiler/lib/src/un...
File pkg/compiler/lib/src/universe/function_set.dart (right):

https://codereview.chromium.org/1422323007/diff/40001/pkg/compiler/lib/src/un...
pkg/compiler/lib/src/universe/function_set.dart:69: Iterable<Element>
filter(Selector selector, ReceiverConstraint mask) {
rename all [mask] to [constraint]? or add TODO?

[Harry Terkelsen, 2015-11-12 01:25:40]

https://codereview.chromium.org/1422323007/diff/40001/pkg/compiler/lib/src/en...
File pkg/compiler/lib/src/enqueue.dart (right):

https://codereview.chromium.org/1422323007/diff/40001/pkg/compiler/lib/src/en...
pkg/compiler/lib/src/enqueue.dart:892: final Map<Element, WorldImpact> impacts =
<Element, WorldImpact>{};
On 2015/11/12 01:10:59, Siggi Cherem (dart-lang) wrote:
> since this is only used by dump-info, how about storing this directly in the
> dumpinfo task, and only set it conditionally when dump info is enabled (that
way
> we save the space when it is not)

Johnni and I talked about this today. Johnni is working on a more general
solution to the problem of whether or not to cache WorldImpacts based on if we
need it for dump-info or for deferred-load. The 'impacts' cache should be
temporary, but I'll move it to the dump info task anyways since it's a quick and
harmless change.

https://codereview.chromium.org/1422323007/diff/40001/pkg/compiler/lib/src/un...
File pkg/compiler/lib/src/universe/function_set.dart (right):

https://codereview.chromium.org/1422323007/diff/40001/pkg/compiler/lib/src/un...
pkg/compiler/lib/src/universe/function_set.dart:69: Iterable<Element>
filter(Selector selector, ReceiverConstraint mask) {
On 2015/11/12 01:10:59, Siggi Cherem (dart-lang) wrote:
> rename all [mask] to [constraint]? or add TODO?

Done.

[Harry Terkelsen, 2015-11-12 01:33:54]

Committed patchset #6 (id:100001) manually as
0df916cce0754b090fab72e51ffdaf2dd4d0e670 (presubmit successful).