Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 1422323006: Fixed Native custom element (Closed)

Created:
5 years, 1 month ago by terry
Modified:
5 years, 1 month ago
Reviewers:
Alan Knight
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Removed meaningless line #

Patch Set 3 : Removed nested ifs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -6 lines) Patch
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/html/html_common/conversions_dartium.dart View 1 2 1 chunk +13 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
terry
5 years, 1 month ago (2015-10-29 23:47:17 UTC) #1
Alan Knight
lgtm
5 years, 1 month ago (2015-10-29 23:48:41 UTC) #2
terry
5 years, 1 month ago (2015-10-30 00:06:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
e84f9941e1cf210646aef72e01eefaa993a7b798 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698