Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Issue 1422323005: Serve html report in server mode (Closed)

Created:
5 years, 1 month ago by vsm
Modified:
5 years, 1 month ago
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Serve html report in server mode If this looks good, I can rip out the old message widget code. R=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/770882d3b5919bc6e7b9b189c5a09ca716cc1d66

Patch Set 1 #

Patch Set 2 : Reformat #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -16 lines) Patch
M lib/src/compiler.dart View 1 1 chunk +5 lines, -3 lines 0 comments Download
M lib/src/report/html_reporter.dart View 1 2 chunks +11 lines, -4 lines 0 comments Download
M lib/src/runner/v8_runner.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M lib/src/server/server.dart View 2 chunks +13 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
vsm
5 years, 1 month ago (2015-10-30 02:38:40 UTC) #3
Jennifer Messerly
LGTM. +1 on ripping out message widget
5 years, 1 month ago (2015-10-30 17:10:57 UTC) #4
vsm
Committed patchset #2 (id:20001) manually as 770882d3b5919bc6e7b9b189c5a09ca716cc1d66 (presubmit successful).
5 years, 1 month ago (2015-10-30 17:58:19 UTC) #5
devoncarew
5 years, 1 month ago (2015-10-30 18:32:54 UTC) #6
Message was sent while issue was closed.
lgtm

lgtm :)

Powered by Google App Engine
This is Rietveld 408576698