Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 1422313003: clang/win: Fix -Wunused-function warnings after https://codereview.chromium.org/1420003004/ (Closed)

Created:
5 years, 1 month ago by Nico
Modified:
5 years, 1 month ago
Reviewers:
jianli
CC:
chromium-reviews, Mathieu
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang/win: Fix -Wunused-function warnings after https://codereview.chromium.org/1420003004/ Fixes: ..\..\components/leveldb_proto/proto_database_impl.h(102,6) : error: unused function 'InitFromTaskRunner' [-Werror,-Wunused-function] void InitFromTaskRunner(LevelDB* database, const base::FilePath& database_dir, ^ ..\..\components/leveldb_proto/proto_database_impl.h(110,6) : error: unused function 'DestroyFromTaskRunner' [-Werror,-Wunused-function] void DestroyFromTaskRunner(const base::FilePath& database_dir, bool* success) { ^ Defining non-inline functions in a .h file generally can't work, so the warning pointed at bad code here. BUG=82385 TBR=jianli

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M components/leveldb_proto/proto_database_impl.h View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Nico
actually, let me fix this myself
5 years, 1 month ago (2015-10-28 03:33:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1422313003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1422313003/1
5 years, 1 month ago (2015-10-28 03:33:29 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3402cf119541d1b9cca88fe0621d4b2c5193afdb Cr-Commit-Position: refs/heads/master@{#356509}
5 years, 1 month ago (2015-10-28 03:59:44 UTC) #6
Nico
5 years, 1 month ago (2015-10-28 03:59:56 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) to pending queue manually as
7ed1fdcc30f3798a3c0ebe12dfc7743c77dd4f3d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698