Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Issue 1422263002: refactor I420AlphaToABGR to use I420AlphaToARGB internally (Closed)

Created:
5 years, 1 month ago by fbarchard1
Modified:
5 years, 1 month ago
Reviewers:
harryjin, harryjin1
CC:
xhwang
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

refactor I420AlphaToABGR to use I420AlphaToARGB internally swap U and V and transpose conversion matrix, so I420AlphaToARGB and I420AlphaToABGR share low level code. Having less code with same performance allows more focused optimization for future ARM versions. R=harryjin@google.com TBR=harryjin@chromium.org BUG=libyuv:473, libyuv:516 Committed: https://chromium.googlesource.com/libyuv/libyuv/+/b86dbf24d30308aafca025018f13fc106c36e55b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -355 lines) Patch
M README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M include/libyuv/row.h View 8 chunks +0 lines, -38 lines 0 comments Download
M include/libyuv/version.h View 1 chunk +1 line, -1 line 0 comments Download
M source/convert_argb.cc View 5 chunks +44 lines, -114 lines 0 comments Download
M source/row_any.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M source/row_common.cc View 1 chunk +0 lines, -28 lines 0 comments Download
M source/row_gcc.cc View 2 chunks +0 lines, -69 lines 0 comments Download
M source/row_win.cc View 3 chunks +0 lines, -102 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
fbarchard1
5 years, 1 month ago (2015-10-27 17:57:24 UTC) #1
fbarchard
Windows 32 bit performance I420AlphaToARGB_Any (616 ms) I420AlphaToARGB_Unaligned (514 ms) I420AlphaToARGB_Invert (492 ms) I420AlphaToARGB_Opt (496 ...
5 years, 1 month ago (2015-10-27 18:19:31 UTC) #4
harryjin
lgtm
5 years, 1 month ago (2015-10-27 20:36:53 UTC) #6
fbarchard1
5 years, 1 month ago (2015-10-27 21:17:27 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b86dbf24d30308aafca025018f13fc106c36e55b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698