Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1053)

Issue 1422233002: Revert of BackgroundHTMLParser: Introduce ParsedChunkQueue to pass ParsedChunks to main thread (Closed)

Created:
5 years, 1 month ago by kouhei (in TOK)
Modified:
5 years, 1 month ago
Reviewers:
kinuko, Yoav Weiss, esprehn, tzik
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of BackgroundHTMLParser: Introduce ParsedChunkQueue to pass ParsedChunks to main thread (patchset #6 id:100001 of https://codereview.chromium.org/1394663004/ ) Reason for revert: Failed MSAN: http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Tests/builds/10886/steps/browser_tests/logs/CaptivePortalBrowserTest.GoBackToTimeout Original issue's description: > BackgroundHTMLParser: Introduce ParsedChunkQueue to pass ParsedChunks to main thread > > Before this CL, each ParsedChunk from the background parser thread was > posted as separate tasks, which wasted time in main thread on poor CPU > devices (esp. mobiles). > > This CL attempts to minimize postTask by passing ParsedChunks via > introduced ParsedChunkQueue class and only using postTask to notify > that it is not empty. > > BUG=540988 > > Committed: https://crrev.com/63f797324ae8302ddd405bf4f7b9a03ca3926f8d > Cr-Commit-Position: refs/heads/master@{#356261} TBR=kinuko@chromium.org,tzik@chromium.org,yoav@yoav.ws,esprehn@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=540988 Committed: https://crrev.com/19f48bfcf83b34f0b54c41252d357e44a4857272 Cr-Commit-Position: refs/heads/master@{#356271}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -120 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.h View 3 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.cpp View 3 chunks +3 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.h View 3 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp View 4 chunks +9 lines, -19 lines 0 comments Download
D third_party/WebKit/Source/core/html/parser/ParsedChunkQueue.h View 1 chunk +0 lines, -46 lines 0 comments Download
D third_party/WebKit/Source/core/html/parser/ParsedChunkQueue.cpp View 1 chunk +0 lines, -38 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kouhei (in TOK)
Created Revert of BackgroundHTMLParser: Introduce ParsedChunkQueue to pass ParsedChunks to main thread
5 years, 1 month ago (2015-10-27 11:58:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1422233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1422233002/1
5 years, 1 month ago (2015-10-27 11:58:26 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-27 11:59:02 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 11:59:34 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/19f48bfcf83b34f0b54c41252d357e44a4857272
Cr-Commit-Position: refs/heads/master@{#356271}

Powered by Google App Engine
This is Rietveld 408576698