extensions/extensions.gyp - Issue 142223002: Support -Goutput_dir=blahblah in GN-GYP hybrid mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/extensions.gyp

Issue 142223002: Support -Goutput_dir=blahblah in GN-GYP hybrid mode (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: prefer command line over env if both are specified Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/extensions.gyp

diff --git a/extensions/extensions.gyp b/extensions/extensions.gyp

index 1b4b049e8c0d7f668017b94b19c6d88a856c4059..a1c7020cf88061bfe3d55c068fc567a5bab96e44 100644

--- a/extensions/extensions.gyp

+++ b/extensions/extensions.gyp

@@ -11,6 +11,7 @@

'target_name': 'extensions_common',

'type': 'static_library',

'dependencies': [

+ '../<(gyp_output_dir)/gn_gyp/third_party/re2/re2.gyp:re2',

# TODO(benwells): figure out what to do with the api target and

# api resources compiled into the chrome resource bundle.

# http://crbug.com/162530

@@ -20,7 +21,6 @@

'../chrome/common/extensions/api/api.gyp:api',

'../components/components.gyp:url_matcher',

'../content/content.gyp:content_common',

- '../out/gn_gyp/third_party/re2/re2.gyp:re2',

'include_dirs': [

'..',

« no previous file with comments | « content/content_browser.gypi ('k') | gpu/command_buffer_service.gypi » ('j') | no next file with comments »