Chromium Code Reviews

Unified Diff: src/compiler/simplified-lowering.cc

Issue 1422213002: [turbofan] Introduce simplified NumberBitwise{Or,Xor,And} operators. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Implement Jaro's suggestion. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: src/compiler/simplified-lowering.cc
diff --git a/src/compiler/simplified-lowering.cc b/src/compiler/simplified-lowering.cc
index a5d529557ec235304bef1a299c9487582330dc59..44ab12eef21aa2b93db128db89038c7618c3bf91 100644
--- a/src/compiler/simplified-lowering.cc
+++ b/src/compiler/simplified-lowering.cc
@@ -718,6 +718,13 @@ class RepresentationSelector {
if (lower()) NodeProperties::ChangeOp(node, Float64Op(node));
break;
}
+ case IrOpcode::kNumberBitwiseOr:
+ case IrOpcode::kNumberBitwiseXor:
+ case IrOpcode::kNumberBitwiseAnd: {
+ VisitInt32Binop(node);
+ if (lower()) NodeProperties::ChangeOp(node, Int32Op(node));
+ break;
+ }
case IrOpcode::kNumberShiftLeft: {
VisitBinop(node, kMachInt32, kMachUint32, kMachInt32);
if (lower()) lowering->DoShift(node, lowering->machine()->Word32Shl());

Powered by Google App Engine