Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: src/compiler/verifier.cc

Issue 1422213002: [turbofan] Introduce simplified NumberBitwise{Or,Xor,And} operators. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Use NewNumber instead of NewHeapNumber in the Deoptimizer. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/typer.cc ('k') | src/deoptimizer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/verifier.h" 5 #include "src/compiler/verifier.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <deque> 8 #include <deque>
9 #include <queue> 9 #include <queue>
10 #include <sstream> 10 #include <sstream>
(...skipping 617 matching lines...) Expand 10 before | Expand all | Expand 10 after
628 case IrOpcode::kNumberSubtract: 628 case IrOpcode::kNumberSubtract:
629 case IrOpcode::kNumberMultiply: 629 case IrOpcode::kNumberMultiply:
630 case IrOpcode::kNumberDivide: 630 case IrOpcode::kNumberDivide:
631 case IrOpcode::kNumberModulus: 631 case IrOpcode::kNumberModulus:
632 // (Number, Number) -> Number 632 // (Number, Number) -> Number
633 CheckValueInputIs(node, 0, Type::Number()); 633 CheckValueInputIs(node, 0, Type::Number());
634 CheckValueInputIs(node, 1, Type::Number()); 634 CheckValueInputIs(node, 1, Type::Number());
635 // TODO(rossberg): activate once we retype after opcode changes. 635 // TODO(rossberg): activate once we retype after opcode changes.
636 // CheckUpperIs(node, Type::Number()); 636 // CheckUpperIs(node, Type::Number());
637 break; 637 break;
638 case IrOpcode::kNumberBitwiseOr:
639 case IrOpcode::kNumberBitwiseXor:
640 case IrOpcode::kNumberBitwiseAnd:
641 // (Signed32, Signed32) -> Signed32
642 CheckValueInputIs(node, 0, Type::Signed32());
643 CheckValueInputIs(node, 1, Type::Signed32());
644 CheckUpperIs(node, Type::Signed32());
645 break;
638 case IrOpcode::kNumberShiftLeft: 646 case IrOpcode::kNumberShiftLeft:
639 case IrOpcode::kNumberShiftRight: 647 case IrOpcode::kNumberShiftRight:
640 // (Signed32, Unsigned32) -> Signed32 648 // (Signed32, Unsigned32) -> Signed32
641 CheckValueInputIs(node, 0, Type::Signed32()); 649 CheckValueInputIs(node, 0, Type::Signed32());
642 CheckValueInputIs(node, 1, Type::Unsigned32()); 650 CheckValueInputIs(node, 1, Type::Unsigned32());
643 CheckUpperIs(node, Type::Signed32()); 651 CheckUpperIs(node, Type::Signed32());
644 break; 652 break;
645 case IrOpcode::kNumberShiftRightLogical: 653 case IrOpcode::kNumberShiftRightLogical:
646 // (Unsigned32, Unsigned32) -> Unsigned32 654 // (Unsigned32, Unsigned32) -> Unsigned32
647 CheckValueInputIs(node, 0, Type::Unsigned32()); 655 CheckValueInputIs(node, 0, Type::Unsigned32());
(...skipping 562 matching lines...) Expand 10 before | Expand all | Expand 10 after
1210 replacement->op()->EffectOutputCount() > 0); 1218 replacement->op()->EffectOutputCount() > 0);
1211 DCHECK(!NodeProperties::IsFrameStateEdge(edge) || 1219 DCHECK(!NodeProperties::IsFrameStateEdge(edge) ||
1212 replacement->opcode() == IrOpcode::kFrameState); 1220 replacement->opcode() == IrOpcode::kFrameState);
1213 } 1221 }
1214 1222
1215 #endif // DEBUG 1223 #endif // DEBUG
1216 1224
1217 } // namespace compiler 1225 } // namespace compiler
1218 } // namespace internal 1226 } // namespace internal
1219 } // namespace v8 1227 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/typer.cc ('k') | src/deoptimizer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698