Trying to activate a window in a workspace other than the current is ignored while a system modal d…

ui/views/corewm/focus_controller.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_COREWM_FOCUS_CONTROLLER_H_
 #define UI_VIEWS_COREWM_FOCUS_CONTROLLER_H_
 
 #include "base/compiler_specific.h"
 #include "base/scoped_observer.h"
 #include "ui/aura/client/activation_client.h"
@@ skipping 70 matching lines @@
   virtual void OnWindowDestroying(aura::Window* window) OVERRIDE;
   virtual void OnWindowHierarchyChanging(
       const HierarchyChangeParams& params) OVERRIDE;
   virtual void OnWindowHierarchyChanged(
       const HierarchyChangeParams& params) OVERRIDE;
 
   // Internal implementations that set the focused/active windows, fire events
   // etc. These functions must be called with valid focusable/activatable
   // windows.
   void SetFocusedWindow(aura::Window* window);
-  void SetActiveWindow(aura::Window* window);
+  void SetActiveWindow(aura::Window* requested_window, aura::Window* window);

[sky, 2013/04/23 21:36:42]

Document what requested_window is.

[sschmitz, 2013/04/24 01:23:43]

Done.

 
   // Called when a window's disposition changed such that it and its hierarchy
   // are no longer focusable/activatable. |next| is a valid window that is used
   // as a starting point for finding a window to focus next based on rules.
   void WindowLostFocusFromDispositionChange(aura::Window* window,
                                             aura::Window* next);
 
   // Called when an attempt is made to focus or activate a window via an input
   // event targeted at that window. Rules determine the best focusable window
   // for the input window.
@@ skipping 12 matching lines @@
 
   ScopedObserver<aura::Window, aura::WindowObserver> observer_manager_;
 
   DISALLOW_COPY_AND_ASSIGN(FocusController);
 };
 
 }  // namespace corewm
 }  // namespace views
 
 #endif  // UI_VIEWS_COREWM_FOCUS_CONTROLLER_H_