Trying to activate a window in a workspace other than the current is ignored while a system modal d…

ui/views/corewm/focus_controller.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_COREWM_FOCUS_CONTROLLER_H_
 #define UI_VIEWS_COREWM_FOCUS_CONTROLLER_H_
 
 #include "base/compiler_specific.h"
 #include "base/scoped_observer.h"
 #include "ui/aura/client/activation_client.h"
@@ skipping 66 matching lines @@
 
   // Overridden from aura::WindowObserver:
   virtual void OnWindowVisibilityChanged(aura::Window* window,
                                          bool visible) OVERRIDE;
   virtual void OnWindowDestroying(aura::Window* window) OVERRIDE;
   virtual void OnWindowHierarchyChanging(
       const HierarchyChangeParams& params) OVERRIDE;
   virtual void OnWindowHierarchyChanged(
       const HierarchyChangeParams& params) OVERRIDE;
 
   // Internal implementations that set the focused/active windows, fire events

[sky, 2013/04/24 14:14:53]

Now that you've added a comment for 87 it no longer makes sense to have this
comment span the two. Instead make this comment just for focused and expand the
comment for SetActiveWindow to describe this too. Additionlly newline between
90/91.

[sschmitz, 2013/04/24 15:42:04]

Done.

   // etc. These functions must be called with valid focusable/activatable
   // windows.
   void SetFocusedWindow(aura::Window* window);
-  void SetActiveWindow(aura::Window* window);
+  // |requested window| refers to the window that was passed in to an external
+  // request (e.g.  FocusWindow or ActivateWindow). It may be NULL, e.g. if
+  // SetActiveWindow was not called by an external request. |active_window|
+  // refers to the actual window to be activated, which may be different.
+  void SetActiveWindow(aura::Window* requested_window,
+                       aura::Window* active_window);
 
   // Called when a window's disposition changed such that it and its hierarchy
   // are no longer focusable/activatable. |next| is a valid window that is used
   // as a starting point for finding a window to focus next based on rules.
   void WindowLostFocusFromDispositionChange(aura::Window* window,
                                             aura::Window* next);
 
   // Called when an attempt is made to focus or activate a window via an input
   // event targeted at that window. Rules determine the best focusable window
   // for the input window.
@@ skipping 12 matching lines @@
 
   ScopedObserver<aura::Window, aura::WindowObserver> observer_manager_;
 
   DISALLOW_COPY_AND_ASSIGN(FocusController);
 };
 
 }  // namespace corewm
 }  // namespace views
 
 #endif  // UI_VIEWS_COREWM_FOCUS_CONTROLLER_H_