Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 14222005: Fix TagWatcher when a text node is added. (Closed)

Created:
7 years, 8 months ago by mtomasz
Modified:
7 years, 8 months ago
Reviewers:
jeremya, benwells
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org, satorux1
Visibility:
Public.

Description

Fix TagWatcher when a text node is added. The previous implementation was causing Javascript errors, when a text node got inserted to the document. This patch fixes this issue by checking if the inserted node is an Element node. TEST=(1) Add a <webview...></webview> node in inspector, (2) add <div><webview...></webview></div> node, (3) add text node in inspector. BUG=222663 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194138

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/renderer/resources/extensions/tag_watcher.js View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mtomasz
@benwells, @jeremya: PTAL at this tiny patch. Thanks.
7 years, 8 months ago (2013-04-12 07:19:29 UTC) #1
mtomasz
7 years, 8 months ago (2013-04-12 07:19:43 UTC) #2
jeremya
lgtm with change mentioned below :) https://codereview.chromium.org/14222005/diff/1/chrome/renderer/resources/extensions/tag_watcher.js File chrome/renderer/resources/extensions/tag_watcher.js (right): https://codereview.chromium.org/14222005/diff/1/chrome/renderer/resources/extensions/tag_watcher.js#newcode24 chrome/renderer/resources/extensions/tag_watcher.js:24: if (addedNode instanceof ...
7 years, 8 months ago (2013-04-12 16:41:06 UTC) #3
mtomasz
https://codereview.chromium.org/14222005/diff/1/chrome/renderer/resources/extensions/tag_watcher.js File chrome/renderer/resources/extensions/tag_watcher.js (right): https://codereview.chromium.org/14222005/diff/1/chrome/renderer/resources/extensions/tag_watcher.js#newcode24 chrome/renderer/resources/extensions/tag_watcher.js:24: if (addedNode instanceof Element) { On 2013/04/12 16:41:06, jeremya ...
7 years, 8 months ago (2013-04-15 02:27:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/14222005/7001
7 years, 8 months ago (2013-04-15 02:27:46 UTC) #5
commit-bot: I haz the power
7 years, 8 months ago (2013-04-15 04:53:37 UTC) #6
Message was sent while issue was closed.
Change committed as 194138

Powered by Google App Engine
This is Rietveld 408576698